Repository navigation
fix: @kernel_function: do not mutate shared Annotated metadata dicts - #14479
Open
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Open
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
Conversation
_parse_parameter() called meta.pop('description') on the typing.Annotated
metadata dict, which mutates the caller's dict. When one shared metadata
dict is reused across multiple kernel functions, the description is lost
from all functions after the first decoration.
Replace pop with get() so the shared dict is never modified.
Fixes microsoft#14441.
Wu Shuwen (dajiaohuang)
had a problem deploying
to
github-app-auth
September 25, 2026 08:10 — with
GitHub Actions
Failure
Wu Shuwen (dajiaohuang)
had a problem deploying
to
github-app-auth
September 25, 2026 08:10 — with
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Exclude description from bulk metadata updates to preserve existing description precedence.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
What changed in this PR
Fixes mutation of shared Annotated metadata dictionaries during kernel function decoration.
Changes:
- Replaces destructive metadata access with non-mutating lookup.
- Preserves caller-owned metadata for reuse.
| File | Description |
|---|---|
python/semantic_kernel/functions/kernel_function_decorator.py |
Updates metadata description handling; preserve existing description precedence during bulk updates. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+155
to
157
| if "description" not in ret and (description := meta.get("description")): | ||
| ret["description"] = description | ||
| ret.update(meta) |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
_parse_parameter() called meta.pop("description") on the typing.Annotated metadata dict, which mutates the caller's dict. When one shared metadata dict is reused across multiple kernel functions, the description is lost from all functions after the first decoration.
Reproduction
Fix
Replace meta.pop("description") with meta.get("description") so the shared dict is never modified.
Fixes #14441.