Skip to content

fix: @kernel_function: do not mutate shared Annotated metadata dicts #14479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Wu Shuwen (dajiaohuang) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: @kernel_function: do not mutate shared Annotated metadata dicts #14479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/semantic_kernel/functions/kernel_function_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ def _parse_parameter(name: str, param: Any, default: Any) -> dict[str, Any]:
ret["description"] = meta
elif isinstance(meta, dict):
# only override from the metadata if it is not already set
if "description" not in ret and (description := meta.pop("description", None)):
if "description" not in ret and (description := meta.get("description")):
ret["description"] = description
ret.update(meta)
Comment on lines +155 to 157
else:
Expand Down
Loading