Skip to content

Update Codicons with report-question icon - #340328

Merged
2 commits merged into
mainfrom
eli/update-codicons-report-question
Oct 9, 2026
Merged

2 commits merged into
mainfrom
eli/update-codicons-report-question

Conversation

@eli-w-king

@eli-w-king Elijah King (eli-w-king) commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • update @vscode/codicons to 0.0.46-44 in the root and remote/web manifests and lockfiles
  • register the new reportQuestion Codicon at codepoint 0xecf8

Related: microsoft/vscode-codicons#535

Validation

  • verified signed release tag v0.0.46-44 and artifact integrity
  • confirmed the package contains .codicon-report-question
  • validated both lockfiles through npm's offline cache using the signed release artifact

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 665ae24f-55b9-4b8f-89ac-8c51a1bf08e4
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Base: e8f54c79 Current: 19cd2b4a

No screenshot changes.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Codicons dependency and lockfiles must be updated so the packaged font contains the registered glyph.

1 open finding
What changed in this PR

Registers the new report-question Codicon.

Changes:

  • Maps reportQuestion to codepoint 0xecf8.
  • Package updates remain pending.
File Description
src/​vs/​base/​common/​codiconsLibrary.ts Registers the new icon.

🧠 Review effort: Balanced


💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/vs/base/common/codiconsLibrary.ts
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 665ae24f-55b9-4b8f-89ac-8c51a1bf08e4
@eli-w-king
Elijah King (eli-w-king) marked this pull request as ready for review October 8, 2026 17:26
@eli-w-king Elijah King (eli-w-king) closed this pull request by merging all changes into main in 3cda1c4 Oct 9, 2026
@eli-w-king
Elijah King (eli-w-king) deleted the eli/update-codicons-report-question branch October 9, 2026 21:32
@vs-code-engineering vs-code-engineering Bot added this to the 1.142.0 milestone Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants