Repository navigation
Read built-in number format 17 (mmm-yy) as DateTime - #1035
Merged
michelebastione merged 1 commit intoOct 30, 2026
Merged
michelebastione merged 1 commit into
michelebastione merged 1 commit into
Conversation
The built-in number format 17 was declared with typeof(TimeSpan). ConvertValueByStyleFormat only handles DateTime? and TimeSpan?, so cells using it were returned as the raw OADate serial. Declare it as typeof(DateTime?), like the other built-in date formats (14, 15, 16 and 22). Fixes mini-software#1034
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
Collaborator
|
Thank you for the contribution @pedrorossato! Could you please open a PR for fixing this on the master branch as well? |
michelebastione
merged commit Oct 30, 2026
9557599
into
mini-software:v1.x-maintenance
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1034
The built-in number format 17 (
mmm-yy) was declared withtypeof(TimeSpan).ConvertValueByStyleFormatonly handlesDateTime?andTimeSpan?, so cells using it were returned as the raw OADate serial. This declares it astypeof(DateTime?), like the other built-in date formats (14, 15, 16 and 22).ExcelOpenXmlStyles: format 17 typeTimeSpan→DateTime?.MiniExcelIssueTests.QueryReadsBuiltInDateFormatsAsDateTime: reads the same serial with the built-in date formats 14, 15, 16, 17 and 22 and expects aDateTime; only the 17 case fails without the fix.Helpers.ReplaceStylesXml: test helper mirroringReplaceFirstSheetXml.MiniExcelTestspasses locally (380/380, net10.0, Windows).