Repository navigation
Conversation
1 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR regenerates the Go code for the stream record envelope.
What changed?
.gitmodulespointsproto/apiat themoetemp/apifork, and the pin moves to the envelope commit in Added the stream record envelope to the public API. api#6.stream/v1package withStreamRecordandStreamRecordKind.proxy/interceptor.gogets aStreamRecordcase forbodyandmetadata. Nothing reaches it yet, so no visitor count moves.Part of AI-198 (epic AI-37).
Why?
It's the Go half of the envelope api PR. Go code that reads or writes stream records through a provider needs the type. Nothing here is hand-written. It sits on
mainnow, like the api PR, since the channel regen it used to stack on is paused per the 2026-10-05 design review.How did you test it?
Link to a test plan if any -
make protoran with the same plugin versions as before, except thenexus-genstep: its input, the Nexus yaml inproto/api, doesn't change with the envelope, so its output stays as committed. The generated files and their changed lines match the regen in the earlier version of this PR.make check,go build ./...andgo test -tags protolegacy ./...pass.