Repository navigation
Conversation
Language SDKs generate the envelope from Core's vendored api, so it has to be here before the streams interface can use it. Nothing in Core reads it yet.
This was referenced Oct 5, 2026
Owner
Author
|
Replaced by #38 in the v5 series (phase 1, Signal wake only). The branch stays as a pin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR vendors the stream record envelope into Core's api tree.
What changed?
temporal/api/stream/v1/message.protocomes in as it is in Added the stream record envelope proto. api#4:StreamRecordandStreamRecordKind, nothing else.Part of AI-198 (epic AI-37).
Why?
Language SDKs generate their protos from Core's vendored api. The streams interface in Python uses
StreamRecordas its record format, so the file has to be here before that package can import it. Nothing in Core reads it yet, and nothing imports it, so no Rust code is generated from it. The serde prefix and the payload-limit lines for the package come with the stream api later, when Core starts using the types.How did you test it?
Link to a test plan if any -
The workspace builds,
cargo lint,cargo test-lint,cargo fmt --checkandcargo docare clean, the protos and common unit tests pass, and the vendored file is byte-identical to the api PR.