Skip to content

Support editable combo boxes (bug 1876540) - #22413

Open
calixteman wants to merge 2 commits into
mozilla:masterfrom
calixteman:bug1876540-editable-combo-boxes
Open

calixteman wants to merge 2 commits into
mozilla:masterfrom
calixteman:bug1876540-editable-combo-boxes

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Fixes #10669.

The editable property of choice fields now comes from the Edit flag of
combo boxes instead of being true for every field which isn't read-only.
Editable combo boxes accept custom values and labels, and their typing is
handled as for text fields. Selection replies are flagged, and a rejected
selection restores the previous value.
@calixteman
calixteman requested a review from a team as a code owner November 1, 2026 17:54
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 1, 2026
@github-actions

github-actions Bot commented Nov 1, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

Commit 6273069 (build logs).

Viewer Build Preview
Modern (gulp generic) ✅ viewer.html
Legacy (gulp generic-legacy) ✅ viewer.html

Previews are removed when the PR closes and may be pruned after 30 days without an update.

@codecov-commenter

codecov-commenter commented Nov 1, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 95.52239% with 12 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.60%. Comparing base (0a41533) to head (6273069).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/display/annotation_layer.js 95.50% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22413      +/-   ##
==========================================
+ Coverage   90.58%   90.60%   +0.02%     
==========================================
  Files         278      278              
  Lines       68586    68807     +221     
==========================================
+ Hits        62126    62340     +214     
- Misses       6460     6467       +7     
Flag Coverage Δ
browsertest 66.16% <27.23%> (-0.14%) ⬇️
fonttest 8.99% <ø> (ø)
integrationtest 69.67% <95.52%> (+0.07%) ⬆️
unittest 61.04% <0.37%> (-0.23%) ⬇️
unittestcli 58.79% <0.37%> (-0.22%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 88 untouched benchmarks
⏩ 174 skipped benchmarks1


Comparing calixteman:bug1876540-editable-combo-boxes (6273069) with master (0a41533)2

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on master (6a12ce7) during the generation of this report, so 0a41533 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@calixteman
calixteman force-pushed the bug1876540-editable-combo-boxes branch from 1171cbc to 6273069 Compare November 1, 2026 18:41
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Nov 1, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[LaTeX][forms][hyperref] ChoiceMenu combo not editable

2 participants