Skip to content

Support editable combo boxes (bug 1876540) #22413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
calixteman wants to merge 2 commits into
base: master
Choose a base branch
from
+1,779 −141
Open

Support editable combo boxes (bug 1876540) #22413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
181f4c4
Handle editable combo boxes in the scripting sandbox (bug 1876540)
calixteman Nov 1, 2026
6273069
Support editable combo boxes (bug 1876540)
calixteman Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions l10n/en-US/viewer.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,10 @@ pdfjs-rendering-error = An error occurred while rendering the page.

## Annotations

# .aria-label for the button that opens an editable combo box's choices.
pdfjs-annotation-combo-box-button =
.aria-label = Show choices

# Variables:
# $dateObj (Date) - the modification date and time of the annotation
pdfjs-annotation-date-time-string = { DATETIME($dateObj, dateStyle: "short", timeStyle: "medium") }
Expand Down
3 changes: 2 additions & 1 deletion src/core/annotation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4016,6 +4016,7 @@ class ChoiceWidgetAnnotation extends WidgetAnnotation {

// Process field flags for the display layer.
this.data.combo = this.hasFieldFlag(AnnotationFieldFlag.COMBO);
this.data.edit = this.hasFieldFlag(AnnotationFieldFlag.EDIT);
this.data.multiSelect = this.hasFieldFlag(AnnotationFieldFlag.MULTISELECT);
this._hasText = true;
}
Expand All @@ -4028,7 +4029,7 @@ class ChoiceWidgetAnnotation extends WidgetAnnotation {
id: this.data.id,
value,
defaultValue: this.data.defaultFieldValue,
editable: !this.data.readOnly,
editable: this.data.combo && this.data.edit,
name: this.data.fieldName,
rect: this.data.rect,
numItems: this.data.fieldValue.length,
Expand Down
Loading
Loading