Repository navigation
Localize the regen countdown and fix uk-UA terms - #1008
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Provider Data Stays Siloed |  |
The PR adds provider-specific branching in shared code. In apps/desktop-tauri/src/proof/fixtures/scenarios.ts:1121, ukRegenCountdownScenario matches snap.providerId !== "claude" while mapping al… |
Remove the providerId match from shared scenario logic. Move the Claude-specific fixture mutation into a provider-scoped helper/module, or use a provider-neutral fixture construction path that does not branch on a specific ProviderId in s… |
| Ui Changes Include Windows Proof |  |
The PR changes visible UI behavior: metricRowModel.ts now produces localized regeneration text, and CardMetricRow.tsx renders that value. The available description reports only a Chromium proof wi… |
Provide the complete PR description, or confirm that it contains a screenshot or proof note from a fresh Windows build. The available evidence is insufficient to make the required description check definitive. |
-
Check name Status Explanation Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title is a short imperative summary that accurately covers the localized regeneration countdown and Ukrainian terminology updates. Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Secrets Handled Safely PASS. The PR changes only countdown formatting, locale strings, tests, and synthetic proof data. Added code contains no logging or error sinks, credentials, tokens, cookies, API keys, OAuth values, or… No Unapproved Dependencies The reviewed diff changes only application, locale, test, and proof files. It does not modify any Cargo.toml or package.json, add an npm/yarn lockfile, or change the pinned pnpm packageManager version… Full details: Secrets Handled Safely
-
Explanation
PASS. The PR changes only countdown formatting, locale strings, tests, and synthetic proof data. Added code contains no logging or error sinks, credentials, tokens, cookies, API keys, OAuth values, or authorization headers. The Ukrainian
gemini auth logintext is an instructional command, not a credential. No credential or keyring files are changed or deleted.
Full details: No Unapproved Dependencies
-
Explanation
The reviewed diff changes only application, locale, test, and proof files. It does not modify any Cargo.toml or package.json, add an npm/yarn lockfile, or change the pinned pnpm packageManager version. No dependency approval is required.
-
Full details: Provider Data Stays Siloed
-
Explanation
The PR adds provider-specific branching in shared code. In
apps/desktop-tauri/src/proof/fixtures/scenarios.ts:1121,ukRegenCountdownScenariomatchessnap.providerId !== "claude"while mapping all provider snapshots. This is outsiderust/src/providers/<name>/andrust/src/core/provider_factory.rs. The changed locale and countdown code does not show an identity or account leak, but the added ProviderId branch independently matches the failure condition.Resolution
Remove the
providerIdmatch from shared scenario logic. Move the Claude-specific fixture mutation into a provider-scoped helper/module, or use a provider-neutral fixture construction path that does not branch on a specific ProviderId in shared code.
Full details: Ui Changes Include Windows Proof
-
Explanation
The PR changes visible UI behavior:
metricRowModel.tsnow produces localized regeneration text, andCardMetricRow.tsxrenders that value. The available description reports only a Chromium proof with mocked IPC and a screenshot, not a fresh Windows build. However, the supplied description is explicitly marked truncated, so omitted text could contain the required Windows proof note or screenshot.Resolution
Provide the complete PR description, or confirm that it contains a screenshot or proof note from a fresh Windows build. The available evidence is insufficient to make the required description check definitive.
✨ Finishing Touches
-
📝 Generate docstrings
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
# Conflicts: # rust/src/locale/uk-UA.ftl
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
|
@coderabbitai Thanks for the pre-merge checks. Answers to both: Provider Data Stays Siloed. UI Changes Include Windows Proof. This change is limited to webview content: localized copy in |
|
Tip For best results, initiate chat on the files or code changes. 🧩 Analysis chain
🧠 Learnings used
You are interacting with an AI system. |
Summary
RegeneratesNowkey covers the zero-remaining case, so the whole sentence is localized rather than the bare word "now".RegeneratesCountdowntemplate now takes a bare duration and owns its own wording. en-US reads "Regenerates in 2d 3h" as before. uk-UA reads "Регенерує через 2 дн. 3 год". Templates for tr-TR, zh-CN and zh-TW were already natural and are unchanged. ja-JP, ko-KR, pt-BR, es-MX and ru-RU were updated to fit the bare duration.CredsGeminiCliSetupHelp: "Установіть Gemini CLI ..." to "Встановіть Gemini CLI ..." (spelling of the imperative).CredsJetBrainsHelperMissing: "Установіть IDE JetBrains ..." to "Встановіть IDE JetBrains ...".DurationDays,DurationDaysHours,DurationDaysMinutes: "{} д" to "{} дн." (the standard abbreviation for days, so "2 дн. 3 год").PaceRunsOutIn: "Закінчується за { }" to "Закінчується через { }".PaceProjectedEmptyIn: "Передбачається порожній у { }" to "За прогнозом, вичерпається через { }".PaceProjectedEmptyNow: "Зараз проектується порожнім" to "За прогнозом, ліміт вичерпано".TokenActivityDaily,WindowLabelDaily: "Щодня" to "Денний".TokenActivityWeekly: "Щотижня" to "Тижневий".ProviderLabelMonthly: "Щомісяця" to "Місячний".UsageSpendTokenInput: "Вхід" to "Вхідні".UsageSpendTokenOutput: "Вихід" to "Вихідні".tray-uk-regen-countdown, shows a regenerating Claude session window under the shipped uk-UA strings. It uses the uk-UA catalog through a newukLocaleOverrideshelper insrc/proof/locale.ts; the rest of the surface stays English because the proof bundle is English-only.Upstream reference: commit 8cb4d93 (steipete#4676). Relevant files:
Sources/CodexBarCore/UsageFormatter.swift(hunks at old lines 107 and 155) and theuk.lprojcatalogs. The Windows port keeps its own formatter; the upstreamresetCountdownDurationsplit is not ported, and the Widget catalog is out of scope for Windows.Files changed:
apps/desktop-tauri/src/lib/metricRowModel.ts:regenCountdownremoved;regenTextusesformatCountdownandRegeneratesNow.apps/desktop-tauri/src/lib/metricRowModel.test.ts: en-US and uk-UA regen cases, and a ja-JP case.apps/desktop-tauri/src/i18n/keyGroups/providerText.ts: addsRegeneratesNow.apps/desktop-tauri/src/proof/fixtures/scenarios.ts: newuk-regen-countdownfixture.apps/desktop-tauri/src/proof/locale.ts: newukLocaleOverrideshelper.apps/desktop-tauri/scripts/proof-scenarios.json: newtray-uk-regen-countdownscenario.rust/src/locale.rs: adds theRegeneratesNowkey.rust/src/locale/*.ftl(10 files): theRegeneratesCountdowntemplate, the newRegeneratesNowkey, and (uk-UA only) the term corrections above.Checks
pnpm exec vitest run src/proof src/lib/metricRowModel.test.ts: 123 passed, 0 failed (5 files).pnpm test(full frontend): 164 files, 1622 tests passed, 0 failed.pnpm exec tsc --noEmit: clean.pnpm run build: passes (includes thecheck-localeprebuild step).pnpm proof:check: 46 of 46 scenarios passed, including the newtray-uk-regen-countdown. Screenshots are in.proof-out/all/in the worktree (Chromium, mocked IPC). The new screenshot is.proof-out/uk/tray-uk-regen-countdown.png, which shows "Регенерує через 2 дн. 3 год" beside "Session (5h) 22% used".cargo fmt --all: clean.cargo test --manifest-path rust/Cargo.toml --lib locale: 26 passed, 0 failed.cargo clippy --manifest-path rust/Cargo.toml --all-targets -- -D warnings: passes.cargo clippy --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml --all-targets -- -D warnings: passes.cargo test --manifest-path rust/Cargo.toml --lib(full): 5279 passed, 0 failed, 2 ignored. This run was made after building thefake_grok_acpexample, which the grok ACP tests need.cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml(full): 804 passed, 0 failed.Not covered:
Summary by CodeRabbit
Bug Fixes
Localization