Add Windows wheels with netft-cpp 0.3.0 - #2
Conversation
|
Warning Review limit reached
Next review available in: 26 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (27)
📝 WalkthroughWalkthroughThe project updates its native core to 0.3.0, adds Windows UDP transport and static curl wheel support, validates Windows wheels through CI and PE inspection, and releases version 2.1.0 with Windows artifacts included in the platform inventory. ChangesWindows wheel release support
Estimated code review effort: 4 (Complex) | ~60 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubActions
participant Cibuildwheel
participant WheelValidator
participant ArtifactStore
GitHubActions->>Cibuildwheel: build AMD64 Windows wheels
Cibuildwheel->>WheelValidator: run check_wheel.py --self-contained
WheelValidator-->>GitHubActions: return validation result
GitHubActions->>ArtifactStore: upload validated wheel artifacts
ArtifactStore-->>GitHubActions: supply artifacts to assemble
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/wheels.yml:
- Line 112: Pin every actions/checkout usage in .github/workflows/wheels.yml at
lines 20, 42, 81, 112, 150, 188, and 218 to a specific immutable commit SHA
instead of the mutable v7 tag.
In `@tools/check_wheel.py`:
- Around line 57-64: Update validate_windows_dependencies to validate every
imported DLL against an explicit allowlist of permitted Windows and Python
runtime DLLs, rather than only matching curl names. Preserve case-insensitive
matching, and raise WheelValidationError listing any dependency not in the
allowlist.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: df03ab11-7126-4b99-9bd2-28e0606b8a2c
📒 Files selected for processing (24)
.github/workflows/release.yml.github/workflows/wheels.ymlCHANGELOG.mdCMakeLists.txtREADME.mdcore/CMakeLists.txtcore/SNAPSHOT.sha256core/UPSTREAMcore/src/detail/client_impl.cppcore/src/detail/client_impl.hppcore/src/detail/posix_transport.hppcore/src/detail/udp_transport.hppcore/src/detail/udp_transport_posix.cppcore/src/detail/udp_transport_windows.cppcore/src/discovery.cpppixi.tomlpyproject.tomltests/artifact/test_wheel.pytests/python/test_import.pytests/quality/test_wheel_configuration.pytests/release/test_metadata.pytools/build_windows_curl.ps1tools/check_release_artifacts.pytools/check_wheel.py
💤 Files with no reviewable changes (1)
- core/src/detail/posix_transport.hpp
5f59e1e to
f507829
Compare
f507829 to
52eb7a0
Compare
Summary
Validation
Summary by CodeRabbit