Remove redundant and brittle tests - #4
Conversation
📝 WalkthroughWalkthroughTests are simplified across legacy streaming, packaging, release metadata, wheel configuration, and native type-checking. Several workflow and runtime validation modules are removed, while remaining tests use dynamic release metadata and updated generated-cache fixtures. ChangesTest validation updates
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
tests/quality/test_sdist.py (1)
47-54: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winCreate an actual
generated-cachedirectory if directory exclusion is being tested.
path.write_bytes()makescore/.pytest_cache/generated-cachea regular file, so this fixture does not cover a generated-cache directory or nested contents. Create the directory with a marker file and clean it up with directory-aware removal, or rename the fixture to reflect that it is intentionally testing a file.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@tests/quality/test_sdist.py` around lines 47 - 54, Update the pollution fixture in test_sdist.py so the core/.pytest_cache/generated-cache entry is created as a directory containing a marker file, allowing directory exclusion and nested contents to be tested. Adjust the fixture cleanup to remove directories recursively while retaining file cleanup for the other pollution entries.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@tests/quality/test_sdist.py`:
- Around line 47-54: Update the pollution fixture in test_sdist.py so the
core/.pytest_cache/generated-cache entry is created as a directory containing a
marker file, allowing directory exclusion and nested contents to be tested.
Adjust the fixture cleanup to remove directories recursively while retaining
file cleanup for the other pollution entries.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 9d923d04-3251-47ef-a6ae-94e12207cee1
📒 Files selected for processing (9)
tests/python/test_legacy.pytests/quality/test_quality_configuration.pytests/quality/test_sdist.pytests/quality/test_wheel_configuration.pytests/release/test_metadata.pytests/typecheck/mypy.initests/typecheck/native_mutable.pytests/typecheck/native_rejected.pytests/typecheck/native_runtime.py
💤 Files with no reviewable changes (6)
- tests/typecheck/native_mutable.py
- tests/typecheck/native_runtime.py
- tests/typecheck/mypy.ini
- tests/typecheck/native_rejected.py
- tests/quality/test_quality_configuration.py
- tests/quality/test_wheel_configuration.py
This removes tests that duplicated runtime coverage or locked repository configuration, workflow layout, fixed versions, and reader-facing text. Behavioral coverage for the Python API, native bindings, packaging artifacts, release tooling, and security boundaries remains.
Validation:
Summary by CodeRabbit
Tests
Chores