Skip to content

Remove redundant and brittle tests #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
han-xudong merged 1 commit into from
Jul 30, 2026
Merged

Remove redundant and brittle tests #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions tests/python/test_legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,8 +153,8 @@ def test_legacy_get_converted_data_returns_a_new_response_with_wrench_list(
client.disconnect()


def test_legacy_streaming_uses_monotonic_time_and_legacy_printing(
fake_client_factory, native_sample, monkeypatch: pytest.MonkeyPatch, capsys
def test_legacy_streaming_uses_monotonic_time(
fake_client_factory, native_sample, monkeypatch: pytest.MonkeyPatch
) -> None:
client, _ = _legacy_warnings()
client.connect()
Expand All @@ -164,8 +164,7 @@ def test_legacy_streaming_uses_monotonic_time_and_legacy_printing(
monkeypatch.setattr(legacy_module.time, "monotonic", lambda: next(monotonic_values))
monkeypatch.setattr(legacy_module.time, "sleep", sleeps.append)

client.start_streaming(duration=1.0, delay=0.25, print_data=True)
client.start_streaming(duration=1.0, delay=0.25, print_data=False)

assert sleeps == [0.25]
assert "Status: 0x00000010" in capsys.readouterr().out
client.disconnect()
365 changes: 0 additions & 365 deletions tests/quality/test_quality_configuration.py
View file
Open in desktop

This file was deleted.

6 changes: 3 additions & 3 deletions tests/quality/test_sdist.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ def _build_sdist(destination: Path) -> Path:
def test_sdist_excludes_generated_caches_and_is_reproducible(tmp_path: Path) -> None:
checker = _load_sdist_checker()
pollution = (
ROOT / "bindings" / "python" / "__pycache__" / "task10.pyc",
ROOT / "core" / ".pytest_cache" / "task10",
ROOT / "src" / "pynetft" / "__pycache__" / "task10.pyc",
ROOT / "bindings" / "python" / "__pycache__" / "generated-cache.pyc",
ROOT / "core" / ".pytest_cache" / "generated-cache",
ROOT / "src" / "pynetft" / "__pycache__" / "generated-cache.pyc",
)
try:
for path in pollution:
Expand Down
Loading
Loading