Skip to content

Add a delay at the end of the system tests to try avoid a crash#2185

Open
ni-jfitzger wants to merge 2 commits into
ni:masterfrom
ni-jfitzger:wait-on-pytest-process-terminate
Open

Add a delay at the end of the system tests to try avoid a crash#2185
ni-jfitzger wants to merge 2 commits into
ni:masterfrom
ni-jfitzger:wait-on-pytest-process-terminate

Conversation

@ni-jfitzger

@ni-jfitzger ni-jfitzger commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator
  • This contribution adheres to CONTRIBUTING.md.
  • [ ] I've updated CHANGELOG.md if applicable.
  • [ ] I've added tests applicable for this pull request

What does this Pull Request accomplish?

Pytest is intermittently crashing as it finishes running system tests on Linux, since upgrading the VM from RHEL 8.3 to RHEL 9.6. This change adds a workaround to reduce the likelihood of those crashes occurring.

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks.

@codecov-commenter

codecov-commenter commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.32%. Comparing base (dae1b50) to head (9bebeea).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2185   +/-   ##
=======================================
  Coverage   89.32%   89.32%           
=======================================
  Files          73       73           
  Lines       19048    19048           
=======================================
+ Hits        17014    17015    +1     
+ Misses       2034     2033    -1     
Flag Coverage Δ
codegenunittests 84.90% <ø> (ø)
nidcpowersystemtests 94.38% <ø> (+0.04%) ⬆️
nidcpowerunittests 89.53% <ø> (ø)
nidigitalsystemtests 92.02% <ø> (ø)
nidigitalunittests 68.44% <ø> (ø)
nidmmsystemtests 92.29% <ø> (ø)
nifakeunittests 86.01% <ø> (ø)
nifgensystemtests 94.32% <ø> (ø)
nimodinstsystemtests 73.85% <ø> (ø)
nimodinstunittests 94.20% <ø> (ø)
nirfsgsystemtests 81.12% <ø> (ø)
niscopesystemtests 89.96% <ø> (ø)
niscopeunittests 43.20% <ø> (ø)
nisesystemtests 91.50% <ø> (ø)
niswitchsystemtests 81.56% <ø> (ø)
nitclksystemtests 94.87% <ø> (ø)
nitclkunittests 98.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dae1b50...9bebeea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ni-jfitzger
ni-jfitzger marked this pull request as ready for review July 17, 2026 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants