Skip to content

Add a delay at the end of the system tests to try avoid a crash #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ni-jfitzger merged 2 commits into from
Jul 19, 2026
Merged

Add a delay at the end of the system tests to try avoid a crash #2185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
487425c
Add a delay at the end of the system tests to try avoid a crash
ni-jfitzger Jul 17, 2026
9bebeea
Add a comment to the new plugin
ni-jfitzger Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build/templates/tox-system_tests.ini.mako
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ commands =
% endif
${module_name}-system_tests: python -c "import ${module_name}; ${module_name}.print_diagnostic_information()"
${module_name}-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source ${module_name} --parallel-mode -m pytest ../../src/${module_name}/examples --junitxml=../junit/junit-${module_name}-{envname}-examples-{env:BITNESS:64}.xml {posargs}
${module_name}-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source ${module_name} --parallel-mode -m pytest ../../src/${module_name}/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-${module_name}-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
${module_name}-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source ${module_name} --parallel-mode -m pytest ../../src/${module_name}/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-${module_name}-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

${module_name}-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -103,6 +103,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nidcpower/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ commands =
nidcpower-system_tests: python -m pip install --disable-pip-version-check --upgrade pip
nidcpower-system_tests: python -c "import nidcpower; nidcpower.print_diagnostic_information()"
nidcpower-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidcpower --parallel-mode -m pytest ../../src/nidcpower/examples --junitxml=../junit/junit-nidcpower-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nidcpower-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidcpower --parallel-mode -m pytest ../../src/nidcpower/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nidcpower-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nidcpower-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidcpower --parallel-mode -m pytest ../../src/nidcpower/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nidcpower-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nidcpower-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -53,6 +53,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nidigital/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =
nidigital-system_tests: python ../../tools/install_local_wheel.py --driver nitclk --start-path ../..
nidigital-system_tests: python -c "import nidigital; nidigital.print_diagnostic_information()"
nidigital-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidigital --parallel-mode -m pytest ../../src/nidigital/examples --junitxml=../junit/junit-nidigital-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nidigital-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidigital --parallel-mode -m pytest ../../src/nidigital/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nidigital-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nidigital-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidigital --parallel-mode -m pytest ../../src/nidigital/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nidigital-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nidigital-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -62,6 +62,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nidmm/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ commands =
nidmm-system_tests: python -m pip install --disable-pip-version-check --upgrade pip
nidmm-system_tests: python -c "import nidmm; nidmm.print_diagnostic_information()"
nidmm-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidmm --parallel-mode -m pytest ../../src/nidmm/examples --junitxml=../junit/junit-nidmm-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nidmm-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidmm --parallel-mode -m pytest ../../src/nidmm/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nidmm-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nidmm-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nidmm --parallel-mode -m pytest ../../src/nidmm/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nidmm-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nidmm-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -53,6 +53,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nifake/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =
nifake-system_tests: python ../../tools/install_local_wheel.py --driver nitclk --start-path ../..
nifake-system_tests: python -c "import nifake; nifake.print_diagnostic_information()"
nifake-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nifake --parallel-mode -m pytest ../../src/nifake/examples --junitxml=../junit/junit-nifake-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nifake-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nifake --parallel-mode -m pytest ../../src/nifake/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nifake-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nifake-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nifake --parallel-mode -m pytest ../../src/nifake/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nifake-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nifake-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -61,6 +61,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nifgen/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =
nifgen-system_tests: python ../../tools/install_local_wheel.py --driver nitclk --start-path ../..
nifgen-system_tests: python -c "import nifgen; nifgen.print_diagnostic_information()"
nifgen-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nifgen --parallel-mode -m pytest ../../src/nifgen/examples --junitxml=../junit/junit-nifgen-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nifgen-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nifgen --parallel-mode -m pytest ../../src/nifgen/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nifgen-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nifgen-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nifgen --parallel-mode -m pytest ../../src/nifgen/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nifgen-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nifgen-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -61,6 +61,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nimodinst/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ commands =
nimodinst-system_tests: python -m pip install --disable-pip-version-check --upgrade pip
nimodinst-system_tests: python -c "import nimodinst; nimodinst.print_diagnostic_information()"
nimodinst-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nimodinst --parallel-mode -m pytest ../../src/nimodinst/examples --junitxml=../junit/junit-nimodinst-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nimodinst-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nimodinst --parallel-mode -m pytest ../../src/nimodinst/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nimodinst-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nimodinst-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nimodinst --parallel-mode -m pytest ../../src/nimodinst/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nimodinst-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nimodinst-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -52,6 +52,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nirfsg/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =
nirfsg-system_tests: python ../../tools/install_local_wheel.py --driver nitclk --start-path ../..
nirfsg-system_tests: python -c "import nirfsg; nirfsg.print_diagnostic_information()"
nirfsg-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nirfsg --parallel-mode -m pytest ../../src/nirfsg/examples --junitxml=../junit/junit-nirfsg-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nirfsg-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nirfsg --parallel-mode -m pytest ../../src/nirfsg/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nirfsg-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nirfsg-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nirfsg --parallel-mode -m pytest ../../src/nirfsg/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nirfsg-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nirfsg-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -61,6 +61,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/niscope/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =
niscope-system_tests: python ../../tools/install_local_wheel.py --driver nitclk --start-path ../..
niscope-system_tests: python -c "import niscope; niscope.print_diagnostic_information()"
niscope-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source niscope --parallel-mode -m pytest ../../src/niscope/examples --junitxml=../junit/junit-niscope-{envname}-examples-{env:BITNESS:64}.xml {posargs}
niscope-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source niscope --parallel-mode -m pytest ../../src/niscope/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-niscope-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
niscope-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source niscope --parallel-mode -m pytest ../../src/niscope/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-niscope-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

niscope-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -61,6 +61,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nise/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ commands =
nise-system_tests: python -m pip install --disable-pip-version-check --upgrade pip
nise-system_tests: python -c "import nise; nise.print_diagnostic_information()"
nise-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nise --parallel-mode -m pytest ../../src/nise/examples --junitxml=../junit/junit-nise-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nise-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nise --parallel-mode -m pytest ../../src/nise/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nise-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nise-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nise --parallel-mode -m pytest ../../src/nise/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nise-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nise-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -52,6 +52,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/niswitch/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ commands =
niswitch-system_tests: python -m pip install --disable-pip-version-check --upgrade pip
niswitch-system_tests: python -c "import niswitch; niswitch.print_diagnostic_information()"
niswitch-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source niswitch --parallel-mode -m pytest ../../src/niswitch/examples --junitxml=../junit/junit-niswitch-{envname}-examples-{env:BITNESS:64}.xml {posargs}
niswitch-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source niswitch --parallel-mode -m pytest ../../src/niswitch/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-niswitch-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
niswitch-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source niswitch --parallel-mode -m pytest ../../src/niswitch/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-niswitch-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

niswitch-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -53,6 +53,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
5 changes: 4 additions & 1 deletion generated/nitclk/tox-system_tests.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ commands =
nitclk-system_tests: python ../../tools/install_local_wheel.py --driver niscope --start-path ../..
nitclk-system_tests: python -c "import nitclk; nitclk.print_diagnostic_information()"
nitclk-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nitclk --parallel-mode -m pytest ../../src/nitclk/examples --junitxml=../junit/junit-nitclk-{envname}-examples-{env:BITNESS:64}.xml {posargs}
nitclk-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nitclk --parallel-mode -m pytest ../../src/nitclk/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nitclk-{envname}-{env:BITNESS:64}.xml --durations=5 {posargs}
nitclk-system_tests: coverage run --rcfile=../../tools/coverage_system_tests.rc --source nitclk --parallel-mode -m pytest ../../src/nitclk/system_tests -c tox-system_tests.ini --junitxml=../junit/junit-nitclk-{envname}-{env:BITNESS:64}.xml --durations=5 -p system_test_pytest_delay_terminate_plugin {posargs}

nitclk-coverage: coverage combine --rcfile=../../tools/coverage_system_tests.rc ./
# Create the report to upload
Expand Down Expand Up @@ -60,6 +60,9 @@ passenv =
JENKINS_URL
BUILD_NUMBER

setenv =
PYTHONPATH = ../../src/shared

[pytest]
addopts = --verbose
filterwarnings =
Expand Down
6 changes: 6 additions & 0 deletions src/shared/system_test_pytest_delay_terminate_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
import time


def pytest_sessionfinish(session, exitstatus):
# Work around a race condition that can cause a crash during process termination.
time.sleep(5)
Loading