Repository navigation
Fix: Use @type in the scheduledsession-split example + GoodRelations backup - #212
Merged
Merged
Conversation
The beta:sportsActivityLocation item used "type" instead of "@type", the same mistake fixed in facilityuse_example_1.json in #181. It was the last 2.x example using "type". The generated models-ts example tests check each example against the TypeScript types, so this example stopped the models-ts build. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The models spec downloads the GoodRelations ontology to check the GoodRelations terms the models use. Its site now returns 401 Unauthorized (for http://purl.org/goodrelations/v1.owl and the heppnetz.de address it redirects to), so the spec failed for every pull request. The spec still downloads the ontology from its purl first. If that fails (network error or timeout, a non-200 response, or a response that is not usable RDF/XML), it uses a copy of the final release (V 1.0, 2011-10-01, CC BY 3.0, from the Internet Archive) in spec/vocabularies, and flags it: a warning in the test output and, on GitHub Actions, a warning annotation on the run. spec/ is excluded from the npm package by .npmignore. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
howaskew
changed the title
hkir-dev
requested changes
Oct 22, 2026
Following review: restore parseRDFXML to its original signature and behaviour, so the SKOS download is unaffected, and move the fallback to a separate parseRDFXMLWithFallback(uri, fallbackFile), used only for GoodRelations. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
hkir-dev
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging releases 3.0.11 to npm and triggers updates in the downstream repositories.
Example fix
The beta:sportsActivityLocation item used "type" instead of "@type", the same mistake fixed in facilityuse_example_1.json in #181. It was the last 2.x example using "type".
The generated models-ts example tests check each example against the TypeScript types, so this example stopped the models-ts build.
Test fix: GoodRelations
The models spec downloaded the GoodRelations ontology from http://www.heppnetz.de/ontologies/goodrelations/v1.owl, which was returning 401 Unauthorized (as does http://purl.org/goodrelations/v1, which redirects there). The
testcheck therefore failed on every pull request.Now, the spec still attempts to download the ontology from http://purl.org/goodrelations/v1.owl first. If that fails (network error or timeout, a non-200 response, or a response that is not usable RDF/XML), it uses a copy of the final release (V 1.0, 2011-10-01, CC BY 3.0, from the Internet Archive) in
spec/vocabularies/goodrelations-v1.owl, and flags it:WARNING: Could not load http://purl.org/goodrelations/v1.owl (HTTP 401). Using the local copy spec/vocabularies/goodrelations-v1.owl instead.The copy gives the same 196 terms as the live file, including the three the models use (
PaymentMethod,Cash,PaymentMethodCreditCard).spec/is excluded from the npm package.Verification
npm test: 5,906 specs, 0 failures, with the purl currently returning 401 (falls back and warns).When squash-merging, check the suggested commit message does not contain a skip-CI marker.