Repository navigation
test(sdk): run independent npm archive checks together - #2011
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
alandelong-oai
left a comment
There was a problem hiding this comment.
No blocking findings in this owner-level merge-safety pass on b479c46. Thank you for running the independent archive checks together while preserving their assertions, deadlines, and the wait for all readers before fixture cleanup.
All 60 archive tests (231 assertions) passed with Bun 1.3.14; build:ci, type checks and formatting also passed. The test run used process-scoped NODE_NO_WARNINGS=1 for an unrelated experimental Node warning on stderr. macOS timing was not reproduced locally, and hosted SDK checks were still running at inspection.
Summary
A macOS SDK shard reached the 30-second case timeout while validating an npm archive. The test had already extracted the archive, installed it with npm, and checked the installed files. A controlled reproduction reached the same point with each individual command taking less than 30 seconds. Failing macOS job
Changes
Run native tar, the offline npm install, and the package validator concurrently for the 15 archive representations. All three read the same finished archive. The test waits for every reader before inspecting the results and removing the temporary directory. It checks each tool’s exit status and the installed bytes as before.
Testing
build:ci,types,format, andgit diff --checkpassed.main, all 15 fixture archives contained four additional dist files. The full 60 cases and 231 assertions passed with both GNU tar 1.35 and bsdtar 3.5.3. Each tar implementation produced the same installed bytes and validator decisions on the newer base and the PR. Package manifest changeRisk and rollout
This changes execution order inside one SDK test. Each representation has its own temporary directory, native extraction directory, and npm cache. The existing per-command and per-test deadlines continue to enforce the selected limits.
Public disclosure review