Skip to content

test(sdk): run independent npm archive checks together #2011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mldangelo-oai merged 3 commits into from
Oct 25, 2026
Merged

test(sdk): run independent npm archive checks together #2011

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b479c46
test(sdk): run independent npm archive checks together
mldangelo-oai Oct 25, 2026
584f0b5
Merge main into npm archive check tests
mldangelo-oai Oct 25, 2026
1054329
Merge current main into npm archive check tests
mldangelo-oai Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 21 additions & 16 deletions sdk/typescript/tests-ts/package-tar-listing.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,15 +652,6 @@ describe("npm package tar listings", () => {
),
);
const native = mkdtempSync(join(root, "native-"));
// The wrong-long-name fixtures have no portable asset path to select.
const extracted = await execFileAsync(
"tar",
["-xzf", archivePath, "-C", native, ...(wrongLongName ? [] : [path])],
{ encoding: "buffer", timeout: 30_000, windowsHide: true },
);
expect(extracted.stderr.toString()).toBe("");
if (!wrongLongName)
expect(readFileSync(join(native, path)).equals(logo)).toBe(true);
const contractPath = join(root, "contract.json");
writeFileSync(
contractPath,
Expand All @@ -674,7 +665,26 @@ describe("npm package tar listings", () => {
npm_config_cache: join(root, "npm-cache"),
};
delete environment["CODEX_SECURITY_EXPECTED_GIT_HEAD"];
const installed = await installPackage(root, archivePath, environment);
const packageCheck = checkPackage(
root,
archivePath,
contractPath,
environment,
);
// The wrong-long-name fixtures have no portable asset path to select.
const extraction = execFileAsync(
"tar",
["-xzf", archivePath, "-C", native, ...(wrongLongName ? [] : [path])],
{ encoding: "buffer", timeout: 30_000, windowsHide: true },
);
const installation = installPackage(root, archivePath, environment);
// All three read the same archive. Keep it until every reader exits, including on failure.
await Promise.allSettled([extraction, installation, packageCheck]);
const extracted = await extraction;
expect(extracted.stderr.toString()).toBe("");
if (!wrongLongName)
expect(readFileSync(join(native, path)).equals(logo)).toBe(true);
const installed = await installation;
const consumer = join(root, "consumer");
expect({
status: installed.status,
Expand Down Expand Up @@ -714,12 +724,7 @@ describe("npm package tar listings", () => {
).toBe(compatible);
if (overwrite)
expect(readFileSync(installedLogo).equals(stored)).toBe(true);
const checked = await checkPackage(
root,
archivePath,
contractPath,
environment,
);
const checked = await packageCheck;
expect({
status: checked.status,
stderr: compatible ? checked.stderr : "",
Expand Down
Loading