Skip to content

chore(api): describe 30-minute cache-write usage counts - #551

Merged
jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-218
Oct 19, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
castiron/promotions/pr-218

Conversation

@jbeckwith-oai

@jbeckwith-oai jbeckwith-oai commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Describe the optional 30-minute cache-write token metric in usage results.

Changes

  • Document input_cache_write_30m_tokens for completions and Decisions usage.
  • Keep command flags and request behavior unchanged.

Validation

  • The diff is limited to the transformed API reference and generation metadata; no response decoder or command code changes.

Castiron-Internal-PR: openai/openai-cli-internal#218
Castiron-Source-SHA: 1cf95e47a160aebd997cb75136714a74e4b6721a
Castiron-Public-Base-SHA: 1666251
@jbeckwith-oai
jbeckwith-oai marked this pull request as ready for review October 19, 2026 18:11
@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 19, 2026 18:11
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-19T18:13:08.782955Z f19dc90 Draft marked ready
🔒 Security Review ✅ Completed 2026-10-19T18:14:03.540646Z f19dc90 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Castiron custom code

Evaluated main: 16662513ea347c92f911c6568203449620642522.

Trusted main policy: 16662513ea347c92f911c6568203449620642522.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared 16662513ea34 → f19dc90a6d6b. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39300577502 --repo openai/openai-cli \
  --name castiron-custom-code-39300577502-1 --dir /tmp/castiron-custom-code-39300577502-1
git apply --stat /tmp/castiron-custom-code-39300577502-1/custom-code.patch
cat /tmp/castiron-custom-code-39300577502-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 16662513ea347c92f911c6568203449620642522 f19dc90a6d6b561d34744a51245694b3ebceb009
python3 scripts/castiron/custom_code_report.py report \
  --base 16662513ea347c92f911c6568203449620642522 \
  --head f19dc90a6d6b561d34744a51245694b3ebceb009 --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-f19dc90a6d6b
cat /tmp/castiron-custom-code-f19dc90a6d6b/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@markstuart-oai markstuart-oai left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed f19dc90a6d6b561d34744a51245694b3ebceb009.

The reference schema adds the optional, nullable counter to completions and Decisions without changing required fields. The diff is limited to the schema and generation metadata; command code and runtime dependencies are unchanged.

No blocking findings. Source review only; I did not run the code or tests locally. Observed checks for this commit passed or were skipped; the WSL rerun passed.

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 19, 2026
Merged via the queue into main with commit e963b2f Oct 19, 2026
60 of 61 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the castiron/promotions/pr-218 branch October 19, 2026 18:37
@openai-sdks openai-sdks Bot mentioned this pull request Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants