Skip to content

refactor(app): move help assembly out of custom - #561

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/layout-help-assembly
Oct 20, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
codex/layout-help-assembly

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Change

Move help assembly and its existing tests from pkg/custom to internal/app, alongside invocation wiring. Update callers directly; no compatibility wrappers or new abstractions. Help rendering stays in internal/clihelp.

The implementation is identical except for its package declaration. Configuration order, help text, hidden credential values, and image/admin guidance are preserved. Generated sources, dependencies, and budget policy are untouched.

Validation

  • go test ./internal/app ./internal/clihelp -count=1
  • go test ./... -run '^$'
  • Windows ARM64 compilation of app and help packages
  • Basic diff review and git diff --check
  • Full go vet ./... reports four unkeyed-literal warnings in unchanged pkg/custom tests.
  • Focused executable help presentation, admin credential help, and image command order contracts passed.
  • Broader TestMain.*Help selection hit one sandbox filesystem limitation: the batch directory helper's invalid-UTF-8 directory creation returned operation not permitted. No help test failure was reported.
  • Focused go vet ./internal/app ./internal/clihelp passed.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 20, 2026 01:30
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T01:31:47.677114Z b9a4c96 PR opened
🔒 Security Review ✅ Completed 2026-10-20T01:32:57.137376Z b9a4c96 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Castiron custom code

Evaluated main: 6ec670807e4d9b81d5c58690901c80e121822806.

Trusted main policy: 6ec670807e4d9b81d5c58690901c80e121822806.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared 6ec670807e4d → b9a4c9666f25. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39353828741 --repo openai/openai-cli \
  --name castiron-custom-code-39353828741-1 --dir /tmp/castiron-custom-code-39353828741-1
git apply --stat /tmp/castiron-custom-code-39353828741-1/custom-code.patch
cat /tmp/castiron-custom-code-39353828741-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 6ec670807e4d9b81d5c58690901c80e121822806 b9a4c9666f254f4d45e300ba374df333b3a5108f
python3 scripts/castiron/custom_code_report.py report \
  --base 6ec670807e4d9b81d5c58690901c80e121822806 \
  --head b9a4c9666f254f4d45e300ba374df333b3a5108f --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-b9a4c9666f25
cat /tmp/castiron-custom-code-b9a4c9666f25/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 7e8300a Oct 20, 2026
67 of 69 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/layout-help-assembly branch October 20, 2026 02:05
@openai-sdks openai-sdks Bot mentioned this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants