Repository navigation
refactor(app): move help assembly out of custom - #561
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39353828741 --repo openai/openai-cli \
--name castiron-custom-code-39353828741-1 --dir /tmp/castiron-custom-code-39353828741-1
git apply --stat /tmp/castiron-custom-code-39353828741-1/custom-code.patch
cat /tmp/castiron-custom-code-39353828741-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 6ec670807e4d9b81d5c58690901c80e121822806 b9a4c9666f254f4d45e300ba374df333b3a5108f
python3 scripts/castiron/custom_code_report.py report \
--base 6ec670807e4d9b81d5c58690901c80e121822806 \
--head b9a4c9666f254f4d45e300ba374df333b3a5108f --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-b9a4c9666f25
cat /tmp/castiron-custom-code-b9a4c9666f25/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Change
Move help assembly and its existing tests from
pkg/customtointernal/app, alongside invocation wiring. Update callers directly; no compatibility wrappers or new abstractions. Help rendering stays ininternal/clihelp.The implementation is identical except for its package declaration. Configuration order, help text, hidden credential values, and image/admin guidance are preserved. Generated sources, dependencies, and budget policy are untouched.
Validation
go test ./internal/app ./internal/clihelp -count=1go test ./... -run '^$'git diff --checkgo vet ./...reports four unkeyed-literal warnings in unchangedpkg/customtests.TestMain.*Helpselection hit one sandbox filesystem limitation: the batch directory helper's invalid-UTF-8 directory creation returnedoperation not permitted. No help test failure was reported.go vet ./internal/app ./internal/clihelppassed.