Skip to content

Repository navigation

refactor(app): own optional first-run setup admission #562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jbeckwith-oai merged 1 commit into from
Oct 20, 2026
Merged

refactor(app): own optional first-run setup admission #562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/architecture/repository-layout.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -355,3 +355,8 @@ Keep release, signing, CODEOWNER, merge-queue, and trusted-main controls intact.
Help assembly and its contracts live in `internal/app/`: root flag descriptions,
feature help content, flag groups, and admin setup guidance are configured there
in the existing order. Rendering remains in `internal/clihelp/`.

Optional first-run shell setup admission lives in `internal/app/`, alongside
invocation. Its existing terminal checks, synchronous audio command traversal,
argument copy, single-worker limit, and 250 ms foreground wait are unchanged.
Image shell installation mechanics remain in `internal/commands/images/`.
2 changes: 1 addition & 1 deletion pkg/custom/audio_first_run_review_test.go → internal/app/audio_first_run_review_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package custom
package app

import (
"context"
Expand Down
4 changes: 2 additions & 2 deletions pkg/custom/audio_skip_setup_test.go → internal/app/audio_skip_setup_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package custom
package app

import (
"context"
Expand Down Expand Up @@ -31,7 +31,7 @@ func audioFirstRunTestRoot() *cli.Command {
Flags: []cli.Flag{&cli.BoolFlag{Name: "all", Hidden: true}}},
}}
requestconfig.ConfigureRootFlags(root)
registerAudioCommands(root)
audiocommands.RegisterLocal(root, audiocommands.LocalOptions{})
root.Command("audio").Command("history").Aliases = []string{"past"}
return root
}
Expand Down
2 changes: 1 addition & 1 deletion pkg/custom/image_first_run_admission_test.go → ...nal/app/image_first_run_admission_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package custom
package app

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion pkg/custom/image_picker_first_run.go → internal/app/image_picker_first_run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package custom
package app

import (
"context"
Expand Down
2 changes: 1 addition & 1 deletion internal/app/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ func Run(ctx context.Context, argv []string) int {
custom.ConfigureCommandErrors(app)

if err == nil {
custom.SetupImagePickerShellOnFirstRun(ctx, argv, app)
SetupImagePickerShellOnFirstRun(ctx, argv, app)
err = custom.RunWithOutputPolicy(ctx, app, func(ctx context.Context) error {
return runWithRequestConfiguration(ctx, app, args, completing)
})
Expand Down
Loading