Repository navigation
refactor(app): own optional first-run setup admission - #562
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Castiron custom codeEvaluated main: Trusted main policy: ✅ No new custom-code files detected. 0 mixed files remain; 0 existing customizations changed. Compared A changed generated baseline means this report cannot reliably identify which handwritten lines changed. Inspect the custom-code diffDownload the exact patch produced by this run (requires repository access): gh run download 39358217324 --repo openai/openai-cli \
--name castiron-custom-code-39358217324-1 --dir /tmp/castiron-custom-code-39358217324-1
git apply --stat /tmp/castiron-custom-code-39358217324-1/custom-code.patch
cat /tmp/castiron-custom-code-39358217324-1/custom-code.patchOr reproduce it from an SDK checkout containing the vendored reporter: git fetch --no-tags origin 7e8300adcef5ccabe13574f9c818401147ff9686 f8588dcd87a499da564039a5d85b8937b2a81fde
python3 scripts/castiron/custom_code_report.py report \
--base 7e8300adcef5ccabe13574f9c818401147ff9686 \
--head f8588dcd87a499da564039a5d85b8937b2a81fde --fetch --require-head-hash --public \
--out /tmp/castiron-custom-code-f8588dcd87a4
cat /tmp/castiron-custom-code-f8588dcd87a4/custom-code.patchThis is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR. |
Move optional first-run shell setup admission and its existing tests from
pkg/customtointernal/app, alongside the invocation that owns it. Update the caller directly; no compatibility wrapper or new abstraction.Production implementation is identical except for its package declaration. Terminal eligibility, synchronous audio command traversal, argument copying, the single-worker gate, and the 250 ms foreground wait remain unchanged. Image shell installation mechanics stay in the image feature. Scanner test fixtures register the same audio commands directly with unused presentation callbacks omitted.
Validation:
go test -race ./internal/app -count=1,go test ./... -run '^$', Windows amd64 app compilation, andgo vet ./internal/apppassed. The existing production-guard PTY test also passed with all standard streams attached. Basic diff review and whitespace checks passed. Generated sources, dependencies, and budget policy are unchanged.