Skip to content

refactor(app): own optional first-run setup admission - #562

Merged
jbeckwith-oai merged 1 commit into
mainfrom
codex/layout-first-run-assembly
Oct 20, 2026
Merged

jbeckwith-oai merged 1 commit into
mainfrom
codex/layout-first-run-assembly

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Move optional first-run shell setup admission and its existing tests from pkg/custom to internal/app, alongside the invocation that owns it. Update the caller directly; no compatibility wrapper or new abstraction.

Production implementation is identical except for its package declaration. Terminal eligibility, synchronous audio command traversal, argument copying, the single-worker gate, and the 250 ms foreground wait remain unchanged. Image shell installation mechanics stay in the image feature. Scanner test fixtures register the same audio commands directly with unused presentation callbacks omitted.

Validation: go test -race ./internal/app -count=1, go test ./... -run '^$', Windows amd64 app compilation, and go vet ./internal/app passed. The existing production-guard PTY test also passed with all standard streams attached. Basic diff review and whitespace checks passed. Generated sources, dependencies, and budget policy are unchanged.

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner October 20, 2026 02:17
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T02:19:34.060162Z f8588dc PR opened
🔒 Security Review ✅ Completed 2026-10-20T02:20:44.385060Z f8588dc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown

Castiron custom code

Evaluated main: 7e8300adcef5ccabe13574f9c818401147ff9686.

Trusted main policy: 7e8300adcef5ccabe13574f9c818401147ff9686.

✅ No new custom-code files detected.

0 mixed files remain; 0 existing customizations changed.

Compared 7e8300adcef5 → f8588dcd87a4. Generated baselines verified.

A changed generated baseline means this report cannot reliably identify which handwritten lines changed.

Inspect the custom-code diff

Download the exact patch produced by this run (requires repository access):

gh run download 39358217324 --repo openai/openai-cli \
  --name castiron-custom-code-39358217324-1 --dir /tmp/castiron-custom-code-39358217324-1
git apply --stat /tmp/castiron-custom-code-39358217324-1/custom-code.patch
cat /tmp/castiron-custom-code-39358217324-1/custom-code.patch

Or reproduce it from an SDK checkout containing the vendored reporter:

git fetch --no-tags origin 7e8300adcef5ccabe13574f9c818401147ff9686 f8588dcd87a499da564039a5d85b8937b2a81fde
python3 scripts/castiron/custom_code_report.py report \
  --base 7e8300adcef5ccabe13574f9c818401147ff9686 \
  --head f8588dcd87a499da564039a5d85b8937b2a81fde --fetch --require-head-hash --public \
  --out /tmp/castiron-custom-code-f8588dcd87a4
cat /tmp/castiron-custom-code-f8588dcd87a4/custom-code.patch

This is the current full custom patch for mixed files, not an attribution of only the handwritten lines changed by this PR.

Full report and patch

@jbeckwith-oai
jbeckwith-oai added this pull request to the merge queue Oct 20, 2026
Merged via the queue into main with commit 4a159a6 Oct 20, 2026
45 checks passed
@jbeckwith-oai
jbeckwith-oai deleted the codex/layout-first-run-assembly branch October 20, 2026 02:36
@openai-sdks openai-sdks Bot mentioned this pull request Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants