Fix click track drift - #2409
Closed
AnAndroNerd wants to merge 1 commit into
Closed
AnAndroNerd wants to merge 1 commit into
AnAndroNerd wants to merge 1 commit into
Conversation
Contributor
Author
|
For Stakira, the failing tests is not a fault of the PR. Please merge #2398 |
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
Pull request overview
Fixes click-track drift by preventing stationary clicks from moving parts while preserving confirmed dragging.
Changes:
- Tracks pointer movement and confirms drag thresholds.
- Skips release updates for stationary clicks.
File summaries
| File | Description |
|---|---|
OpenUtau/Views/PartEditStates.cs |
Adds drag confirmation state. |
OpenUtau/Views/MainWindow.axaml.cs |
Tracks pointer movement and conditionally updates on release. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
AnAndroNerd
added
beta-bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes this https://discord.com/channels/551606189386104834/801525671775043625/1546000653975949345