Skip to content

NO-ISSUE: add VMaaS QE team memberships - #299

Merged
eliorerz merged 1 commit into
osac-project:mainfrom
prabinovRedhat:no-issue/add-vmaas-qe-members
Nov 16, 2026
Merged

eliorerz merged 1 commit into
osac-project:mainfrom
prabinovRedhat:no-issue/add-vmaas-qe-members

Conversation

@prabinovRedhat

Copy link
Copy Markdown
Contributor

Summary

  • Add Polina, Lubov, and Javier to the wg-qe team.
  • Add Lubov and Javier to the wg-vmaas team; Polina is already a member.
  • Add Javier to the organization member list.

Jira

N/A

Test plan

  • pre-commit run --all-files
  • tofu fmt -check
  • CSV duplicate-member validation
  • Apply configuration after merge

The path-specific osac CODEOWNERS change will be handled separately.


This PR description was drafted with AI assistance (create-pr v0.2.0). Review for accuracy.

Add the QE users to wg-qe and wg-vmaas. Add Javier to the

organization member list so the team memberships can apply.

Assisted-by: Codex <noreply@openai.com>
Signed-off-by: prabinov <prabinov@redhat.com>
@prabinovRedhat
prabinovRedhat requested a review from a team November 16, 2026 14:35
@prabinovRedhat
prabinovRedhat requested review from a team as code owners November 16, 2026 14:35
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6ba320b0-e385-4ef5-ae02-a1512dab8567

@eliorerz
eliorerz merged commit 439d357 into osac-project:main Nov 16, 2026
2 checks passed
ori-amizur pushed a commit to ori-amizur/osac that referenced this pull request Nov 17, 2026
## Summary
- Assign `@osac-project/wg-qe` to the five requested `osac-ui` paths.
- Keep the existing `@osac-project/wg-ui` ownership for the rest of
`osac-ui`.
- More-specific rules take precedence over the broad `/osac-ui/` rule.

## Jira
N/A

## Related
- Depends on
[osac-project/github-config#299](osac-project/github-config#299)
for team membership.

## Test plan
- [x] `pre-commit run --files CODEOWNERS`
- [x] `git diff --check`
- [ ] Verify code-owner assignment with a test PR after merge

---

_This PR description was drafted with AI assistance
([create-pr](https://github.com/osac-project/osac-workspace/tree/main/skills/create-pr)
v0.2.0). Review for accuracy._

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

<!-- coderabbit-ai-generated:v1 -->

## Summary of changes

**Affected area:** Repository ownership only. The change edits
`CODEOWNERS` and does not touch code, APIs, controllers, databases,
authentication, deployment, CI pipelines, or documentation.

**File changed:** `CODEOWNERS` (+6 lines, 0 removed; 1 file changed).

**What changed:** The diff adds a comment line and five path rules after
the existing `/osac-ui/ @osac-project/wg-ui` rule:

- `/osac-ui/apps/e2e-tests/` → `@osac-project/wg-qe`
- `/osac-ui/apps/playwright/` → `@osac-project/wg-qe`
- `/osac-ui/libs/locators/` → `@osac-project/wg-qe`
- `/osac-ui/libs/test-utils/` → `@osac-project/wg-qe`
- `/osac-ui/libs/osac-cli/` → `@osac-project/wg-qe`

The broad `/osac-ui/` rule still assigns the rest of `osac-ui` to
`@osac-project/wg-ui`. The more specific rules assign the five paths to
`@osac-project/wg-qe`. CODEOWNERS uses last-match precedence, so these
later rules take effect for matching paths.

**Backward compatibility:** No code or API changes. Review routing
changes for the five paths. Pull requests that touch those paths will
request review from `wg-qe` instead of `wg-ui`.

**Dependencies and open items:**

- The PR depends on osac-project/github-config#299 for team membership.
The `wg-qe` team must exist and contain the required members for the
owner assignments to resolve.
- The PR description reports that `pre-commit run --files CODEOWNERS`
and `git diff --check` passed. Those results come from the PR
description, not from a run in this review.
- The PR description leaves verification of code-owner assignment with a
test PR unchecked.
- The PR references no Jira issue.

**Alterations to exported or public entities:** None.

**Review effort:** Low.

## Risk classification

Not available. The supplied context does not include the labeling
instructions that define `risk:ship`, `risk:show`, and `risk:ask`. No
label is assigned, and no criteria are cited.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->

Signed-off-by: prabinov <prabinov@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants