Repository navigation
NO-ISSUE: add VMaaS QE team memberships - #299
Merged
eliorerz merged 1 commit intoNov 16, 2026
Merged
Conversation
Add the QE users to wg-qe and wg-vmaas. Add Javier to the organization member list so the team memberships can apply. Assisted-by: Codex <noreply@openai.com> Signed-off-by: prabinov <prabinov@redhat.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
2 of 3 tasks
ygalblum
approved these changes
Nov 16, 2026
eliorerz
approved these changes
Nov 16, 2026
ori-amizur
pushed a commit
to ori-amizur/osac
that referenced
this pull request
Nov 17, 2026
## Summary - Assign `@osac-project/wg-qe` to the five requested `osac-ui` paths. - Keep the existing `@osac-project/wg-ui` ownership for the rest of `osac-ui`. - More-specific rules take precedence over the broad `/osac-ui/` rule. ## Jira N/A ## Related - Depends on [osac-project/github-config#299](osac-project/github-config#299) for team membership. ## Test plan - [x] `pre-commit run --files CODEOWNERS` - [x] `git diff --check` - [ ] Verify code-owner assignment with a test PR after merge --- _This PR description was drafted with AI assistance ([create-pr](https://github.com/osac-project/osac-workspace/tree/main/skills/create-pr) v0.2.0). Review for accuracy._ <!-- This is an auto-generated comment: release notes by coderabbit.ai --> <!-- coderabbit-ai-generated:v1 --> ## Summary of changes **Affected area:** Repository ownership only. The change edits `CODEOWNERS` and does not touch code, APIs, controllers, databases, authentication, deployment, CI pipelines, or documentation. **File changed:** `CODEOWNERS` (+6 lines, 0 removed; 1 file changed). **What changed:** The diff adds a comment line and five path rules after the existing `/osac-ui/ @osac-project/wg-ui` rule: - `/osac-ui/apps/e2e-tests/` → `@osac-project/wg-qe` - `/osac-ui/apps/playwright/` → `@osac-project/wg-qe` - `/osac-ui/libs/locators/` → `@osac-project/wg-qe` - `/osac-ui/libs/test-utils/` → `@osac-project/wg-qe` - `/osac-ui/libs/osac-cli/` → `@osac-project/wg-qe` The broad `/osac-ui/` rule still assigns the rest of `osac-ui` to `@osac-project/wg-ui`. The more specific rules assign the five paths to `@osac-project/wg-qe`. CODEOWNERS uses last-match precedence, so these later rules take effect for matching paths. **Backward compatibility:** No code or API changes. Review routing changes for the five paths. Pull requests that touch those paths will request review from `wg-qe` instead of `wg-ui`. **Dependencies and open items:** - The PR depends on osac-project/github-config#299 for team membership. The `wg-qe` team must exist and contain the required members for the owner assignments to resolve. - The PR description reports that `pre-commit run --files CODEOWNERS` and `git diff --check` passed. Those results come from the PR description, not from a run in this review. - The PR description leaves verification of code-owner assignment with a test PR unchecked. - The PR references no Jira issue. **Alterations to exported or public entities:** None. **Review effort:** Low. ## Risk classification Not available. The supplied context does not include the labeling instructions that define `risk:ship`, `risk:show`, and `risk:ask`. No label is assigned, and no criteria are cited. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: prabinov <prabinov@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
wg-qeteam.wg-vmaasteam; Polina is already a member.Jira
N/A
Test plan
pre-commit run --all-filestofu fmt -checkThe path-specific
osacCODEOWNERS change will be handled separately.This PR description was drafted with AI assistance (create-pr v0.2.0). Review for accuracy.