docs: format five pages with prettier - #512
Merged
Merged
Conversation
Docusaurus Lint has been failing on main since a48daff. The signing key, permission split and password hashing changes each edited pages under docs/, which just md-fmt excludes because that tree is Prettier's, not mdformat's. Nothing reformatted them, so docusaurus-fmt-check failed on five files. Formatting only, no content change. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 99.93% 99.94%
=======================================
Files 488 488
Lines 23108 23108
=======================================
+ Hits 23094 23095 +1
+ Misses 14 13 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
retr0h
added a commit
to osapi-io/specs
that referenced
this pull request
Sep 17, 2026
Three merged security fixes each edited pages under docs/ and left five of them unformatted, so Docusaurus Lint failed on main until osapi-io/osapi#512. The skill's verify gate listed just ready and just test, and neither covers the site: md-fmt excludes docs/ because Prettier owns that tree. Also records the fresh-worktree ordering. just ready lints before it builds the UI, so in a new worktree the linter cannot import the embed package and reports a typecheck error on a file nobody touched, which cost two gate runs to recognise. Claude-Session: https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
retr0h
added a commit
that referenced
this pull request
Sep 18, 2026
* fix: check both formatters in the test recipe just test verified justfile formatting only. Markdown and the docs site were covered by CI alone, which is enough for an ordinary pull request but not for a fix merged from a security advisory's private fork: those forks run no Actions, so this recipe is the only gate such a change gets before it reaches main. Three advisory fixes each edited pages under docs/ and left five of them unformatted, so Docusaurus Lint failed on main from a48daff until #512. Both checks now run here, where they would have caught it. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: drop md-fmt-check from the test recipe md-fmt-check runs mdformat through uvx, and the Go workflow installs Go, Node, bun and just but not uv, so just test failed with uvx: not found. Markdown Lint already runs that check in a job that installs uv. docusaurus-fmt-check stays: bun is installed in the Go workflow and the recipe installs the site dependencies itself, and that is the check whose absence let five unformatted pages reach main. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docusaurus Linthas been failing on main sincea48daffe8.The signing-key, permission-split and password-hashing fixes each edited pages under
docs/.just md-fmtexcludes that tree because the Docusaurus site is formatted by Prettier throughjust docusaurus-fmt, and nothing ran it, sodocusaurus-fmt-checkfails on:docs/sidebar/features/authentication.mddocs/sidebar/features/command-execution.mddocs/sidebar/usage/cli/client/node/user/create.mddocs/sidebar/usage/cli/client/node/user/password.mddocs/sidebar/usage/configuration.mdjust docusaurus-fmtoutput only — no content changes.This is a gap in how those fixes were gated:
just readyandjust testdo not cover the site formatter, so a change touchingdocs/needsjust docusaurus-fmt-checkas well. Worth adding to the pre-commit sequence so it cannot recur.🤖 Generated with Claude Code
https://claude.ai/code/session_01FuKUsHFG1EqZXamffh9M2c