Skip to content

Fix broken anchors, untranslated headings, and remove out-of-scope proposal file (Greek translations PR #243 follow-up) - #4

Merged
passadis merged 2 commits into
mainfrom
copilot/fix-broken-anchor-jump-links
Aug 9, 2026
Merged

passadis merged 2 commits into
mainfrom
copilot/fix-broken-anchor-jump-links

Conversation

Copilot AI commented Aug 9, 2026 •

Copy link
Copy Markdown

10 suppressed comments from the latest Copilot review on PR microsoft#243 addressed: broken in-page anchor jump-links across 7 Greek translation files, 2 untranslated headings in lessons 04 and 06, and an out-of-scope proposal file.

Broken anchor jump-links (7 files)

Translating ## Interact with … headings into Greek broke auto-generated anchors that in-page jump links (#interact-with-*) relied on. Added explicit HTML anchors immediately before each heading, matching the pattern already established in lessons/01-intro-to-genai/translations/README.el.md:

<a id="interact-with-leonardo"></a>
## Αλληλεπίδρασε με τον Leonardo

Applied to lessons 02–08 (leonardo, sforza, montezuma, ada-lovelace, amelia-earhart, scipio, hedy-lamarr).

Untranslated headings (2 files)

  • lessons/04-structured-output: ## Structured Output → ## Δομημένη έξοδος (Structured Output)
  • lessons/06-tool-calling: ## Tool calling → ## Κλήση εργαλείων (Tool calling)

Removed out-of-scope file

Deleted docs/proposals/new-lesson-ai-agents.md — a Lesson 09 proposal that was outside the stated scope of this PR (Greek translations only).

…dings, remove proposal file

Co-authored-by: passadis <53148138+passadis@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix broken in-page anchor jump links in translations Fix broken anchors, untranslated headings, and remove out-of-scope proposal file (Greek translations PR #243 follow-up) Aug 9, 2026
Copilot AI requested a review from passadis August 9, 2026 01:30
@passadis
passadis marked this pull request as ready for review August 9, 2026 01:36
Copilot AI lite review requested due to automatic review settings August 9, 2026 01:36
@passadis
passadis merged commit 57ebb66 into main Aug 9, 2026
3 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR follows up on Greek translation PR microsoft#243 by repairing in-page navigation and finishing a couple of partially untranslated section headings, while also removing an unrelated proposal document to keep the translation scope clean.

Changes:

  • Restored broken #interact-with-* jump links in Greek lesson translations by adding explicit HTML anchors immediately before the corresponding “Interact with …” headings (lessons 02–08).
  • Translated two remaining English headings in lessons 04 and 06 while keeping the original English term in parentheses.
  • Removed an out-of-scope Lesson 09 proposal markdown file from docs/proposals/.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
lessons/02-first-ai-app/translations/README.el.md Adds an explicit interact-with-leonardo anchor to keep the existing in-page jump link working.
lessons/03-prompt-engineering/translations/README.el.md Adds an explicit interact-with-sforza anchor to restore in-page navigation.
lessons/04-structured-output/translations/README.el.md Adds an explicit interact-with-montezuma anchor and translates the “Structured Output” heading.
lessons/05-rag/translations/README.el.md Adds an explicit interact-with-ada-lovelace anchor to restore in-page navigation.
lessons/06-tool-calling/translations/README.el.md Adds an explicit interact-with-amelia-earhart anchor and translates the “Tool calling” heading.
lessons/07-mcp/translations/README.el.md Adds an explicit interact-with-scipio anchor to restore in-page navigation.
lessons/08-mcp-advanced/translations/README.el.md Adds an explicit interact-with-hedy-lamarr anchor to restore in-page navigation.
docs/proposals/new-lesson-ai-agents.md Removes an out-of-scope proposal file to keep the PR focused on Greek translations.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants