Repository navigation
docs(diagrams): Geewax voice pass on diagram labels - #91
Merged
Merged
Conversation
Rule 12 (em dash, zero tolerance) applied to the 118 figures that carried one: - Recast every em-dash label in assets/diagrams/*.svg and the matching — in the paired *.excalidraw (text + originalText), keeping each pair in sync. Apposition labels take a colon; clause joins take a comma or period; a few long labels that already held a colon were reworded to avoid a double colon. - Recast the same labels in the diagram generator sources (gen_*.py, generate_example_diagrams.py) so a regenerate stays clean. No diagrams removed; only label punctuation changed. Excalidraw JSON still valid; validate_site.py clean; sample renders checked for overflow.
patterncatalyst
added a commit
that referenced
this pull request
Oct 23, 2026
Rule 12 (em dash, zero tolerance) applied to the 118 figures that carried one: - Recast every em-dash label in assets/diagrams/*.svg and the matching — in the paired *.excalidraw (text + originalText), keeping each pair in sync. Apposition labels take a colon; clause joins take a comma or period; a few long labels that already held a colon were reworded to avoid a double colon. - Recast the same labels in the diagram generator sources (gen_*.py, generate_example_diagrams.py) so a regenerate stays clean. No diagrams removed; only label punctuation changed. Excalidraw JSON still valid; validate_site.py clean; sample renders checked for overflow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies rule 12 (em dash, zero tolerance) to the diagram figures.
What changed
assets/diagrams/*.svg) and the matching—in the 118 paired Excalidraw files (text+originalText), keeping each pair in sync. Apposition → colon; clause joins → comma/period; a few long labels that already held a colon were reworded to avoid a double colon.gen_*.py,generate_example_diagrams.py) so a regenerate stays clean.Content preserved
No diagrams removed; only label punctuation changed (and the examples-matrix "not applicable" glyph, in the earlier chrome PR). The
·separators and→arrows in labels are untouched.Verification
—in SVGs, 0—in Excalidraw; global strict scan 0 ban-tier onassets/diagrams.scripts/validate_site.py42 files, 0 errors; sample renders checked for overflow.Third CNDP PR. Next: footers →
_plans+ Build-run-observe; decks as a follow-on.