Repository navigation
Fix flaky FPM log-bwd-multiple-msgs-stdout-stderr test and remove XFAIL - #24998
Merged
Merged
Conversation
The end of request flush command is written only to the stderr pipe so a stdout message without a trailing newline is terminated only when the master sees the switch to stderr. If the master is not scheduled between the two requests (slow CI), it reads both stdout chunks at once and logs them as a single "msg 1 - msg 1 - " line which made the test fail. Check the log lines after each request so the master always drains the pipes before the next request is sent. This also verifies the output of the second request which was previously not checked.
bukka
added a commit
that referenced
this pull request
Oct 28, 2026
* PHP-8.4: Fix flaky FPM log-bwd-multiple-msgs-stdout-stderr test and remove XFAIL (#24998)
bukka
added a commit
that referenced
this pull request
Oct 28, 2026
* PHP-8.5: Fix flaky FPM log-bwd-multiple-msgs-stdout-stderr test and remove XFAIL (#24998)
bukka
added a commit
that referenced
this pull request
Oct 28, 2026
* PHP-8.6: Fix flaky FPM log-bwd-multiple-msgs-stdout-stderr test and remove XFAIL (#24998)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The end of request flush command is written only to the stderr pipe so a stdout message without a trailing newline is terminated only when the master sees the switch to stderr. If the master is not scheduled between the two requests (slow CI), it reads both stdout chunks at once and logs them as a single "msg 1 - msg 1 - " line which made the test fail.
Check the log lines after each request so the master always drains the pipes before the next request is sent. This also verifies the output of the second request which was previously not checked.