Skip to content

*: upgrade go version to 1.25.14 - #12867

Merged
ti-chi-bot[bot] merged 1 commit into
masterfrom
ldz/upgrade-go-12514
Sep 22, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
masterfrom
ldz/upgrade-go-12514

Conversation

@lidezhu

@lidezhu lidezhu commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

What problem does this PR solve?

Issue Number: close #12868

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

Summary by CodeRabbit

  • Bug Fixes

    • Fixed changefeed restart handling during an in-progress column addition, preventing columns in DeleteOnly state from being incorrectly emitted as NULL values.
  • Tests

    • Added regression coverage for schema recovery and row mounting after a restart during column changes.
  • Chores

    • Updated the project and example modules to use Go 1.25.14 for more consistent builds and integration testing.

@ti-chi-bot ti-chi-bot Bot added do-not-merge/needs-linked-issue release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 1a935861-8b47-4a22-a160-519bda46005a

📥 Commits

Reviewing files that changed from the base of the PR and between 03ed243 and 765500c.

📒 Files selected for processing (7)
  • cdc/entry/mounter_test.go
  • deployments/ticdc/docker/integration-test.Dockerfile
  • examples/golang/avro-checksum-verification/go.mod
  • examples/golang/canal-json-handle-key-only/go.mod
  • go.mod
  • tests/integration_tests/debezium/go.mod
  • tools/check/go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The change adds a regression test for mounter restart behavior with a DeleteOnly column and updates Go toolchain declarations from 1.25.12 to 1.25.14 across the repository.

Changes

Mounter regression coverage

Layer / File(s) Summary
Restarted DeleteOnly column test
cdc/entry/mounter_test.go
The test persists intermediate table metadata, recreates schema storage and the mounter, decodes the physical row, and verifies that the DeleteOnly column is not emitted in DML.

Go version alignment

Layer / File(s) Summary
Go toolchain version updates
deployments/ticdc/docker/integration-test.Dockerfile, go.mod, examples/golang/*/go.mod, tests/integration_tests/debezium/go.mod, tools/check/go.mod
The Docker build toolchain and Go module directives are updated from 1.25.12 to 1.25.14.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Other

Suggested reviewers: asddongmen

Merge Risk: ⚪ Minimal · up to 76550

The change adds regression coverage and aligns Go toolchain versions without evidenced correctness, deployment, or compatibility risk. It is ready to merge with normal checks.

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (6 skipped: 6… Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The description includes the issue number, but the change summary, testing details, compatibility assessment, documentation assessment, and release note are incomplete. The checklist also remains unse… Describe the Go version upgrade and the regression test. Select the applicable test item and remove the others. State whether compatibility or performance changes are expected, address documentation updates, and add a release note or write …
✅ Passed checks (3 passed)
Check name Status Explanation
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the primary change: upgrading the Go version to 1.25.14.
Full details: Docstring Coverage

Explanation

Docstring coverage is 66.67% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (6 skipped: 6 unsupported.)

Full details: Description check

Explanation

The description includes the issue number, but the change summary, testing details, compatibility assessment, documentation assessment, and release note are incomplete. The checklist also remains unselected.

Resolution

Describe the Go version upgrade and the regression test. Select the applicable test item and remove the others. State whether compatibility or performance changes are expected, address documentation updates, and add a release note or write None.

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the columns in a row
DeleteOnly stays hidden below
The mounter restarts, the test runs bright
Go tools hop to a newer height
Metadata settles, outputs align

Comment @coderabbitai help to get the list of available commands.

@lidezhu
lidezhu force-pushed the ldz/upgrade-go-12514 branch from 765500c to 5a8f068 Compare September 22, 2026 01:38
@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.0775%. Comparing base (03ed243) to head (5a8f068).
✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
cdc 57.4490% <ø> (∅)
dm 50.8642% <ø> (∅)
engine 50.6772% <ø> (+0.0225%) ⬆️
Flag Coverage Δ
cdc 57.4490% <ø> (?)
unit 54.0775% <ø> (+3.4228%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             master     #12867        +/-   ##
================================================
+ Coverage   50.6546%   54.0775%   +3.4228%     
================================================
  Files           213       1013       +800     
  Lines         17720     141802    +124082     
================================================
+ Hits           8976      76683     +67707     
- Misses         8178      59365     +51187     
- Partials        566       5754      +5188     
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ti-chi-bot ti-chi-bot Bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. do-not-merge/needs-linked-issue labels Sep 22, 2026
@ti-chi-bot ti-chi-bot Bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 22, 2026
@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@ti-chi-bot ti-chi-bot Bot added the lgtm label Sep 22, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nongfushanquan, wk989898

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 22, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

[LGTM Timeline notifier]

Timeline:

  • 2026-09-22 01:45:43.946332598 +0000 UTC m=+69269.171553706: ☑️ agreed by wk989898.
  • 2026-09-22 02:01:12.906248143 +0000 UTC m=+70198.131469251: ☑️ agreed by nongfushanquan.

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-pulsar-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-kafka-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-storage-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-dm-integration-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-storage-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-mysql-test

1 similar comment
@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-mysql-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-kafka-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/test pull-cdc-integration-storage-test

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-cdc-integration-mysql-test

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-dm-integration-test
/retest

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-dm-integration-test

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-cdc-integration-pulsar-test

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-cdc-integration-kafka-test

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-cdc-integration-storage-test

@wuhuizuo

Copy link
Copy Markdown
Contributor

/test pull-cdc-integration-mysql-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/retest

@ti-chi-bot
ti-chi-bot Bot merged commit 20f7694 into master Sep 22, 2026
38 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the ldz/upgrade-go-12514 branch September 22, 2026 06:29
@lidezhu lidezhu added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Sep 22, 2026
@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator Author

/run-cherry-picker

@ti-chi-bot

Copy link
Copy Markdown
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #12869.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade golang version to 1.25.14

5 participants