Skip to content

*: upgrade go version to 1.25.14 (#12867) - #12869

Merged
ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-12867-to-release-8.5
Sep 23, 2026
Merged

ti-chi-bot[bot] merged 1 commit into
pingcap:release-8.5from
ti-chi-bot:cherry-pick-12867-to-release-8.5

Conversation

@ti-chi-bot

@ti-chi-bot ti-chi-bot commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

This is an automated cherry-pick of #12867

What problem does this PR solve?

Issue Number: close #12868

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

Please refer to [Release Notes Language Style Guide](https://pingcap.github.io/tidb-dev-guide/contribute-to-tidb/release-notes-style-guide.html) to write a quality release note.

If you don't think this PR needs a release note then fill it with `None`.

Summary by CodeRabbit

  • Chores
    • Updated the project and example components to use Go 1.25.14.
    • Updated integration test tooling to build with Go 1.25.14.
    • No user-facing functionality or dependency changes.

@ti-chi-bot ti-chi-bot added lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Sep 22, 2026
@coderabbitai

coderabbitai Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: 82e5d036-6a7e-4be8-baac-69e62d5c49e1

📥 Commits

Reviewing files that changed from the base of the PR and between 66c1d4d and 00454dc.

📒 Files selected for processing (6)
  • deployments/ticdc/docker/integration-test.Dockerfile
  • examples/golang/avro-checksum-verification/go.mod
  • examples/golang/canal-json-handle-key-only/go.mod
  • go.mod
  • tests/integration_tests/debezium/go.mod
  • tools/check/go.mod

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The pull request updates Go version references from 1.25.12 to 1.25.14 in the repository, nested modules, and the integration-test Dockerfile.

Changes

Go Toolchain Alignment

Layer / File(s) Summary
Go module version updates
go.mod, examples/golang/*/go.mod, tests/integration_tests/debezium/go.mod, tools/check/go.mod
The Go version directives change from 1.25.12 to 1.25.14.
Integration-test Docker toolchain
deployments/ticdc/docker/integration-test.Dockerfile
The downloader stage now fetches and installs Go 1.25.14.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 00454

The PR aligns the repository modules and integration-test Docker build with Go 1.25.14, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description includes the required issue reference and template headings, but it does not explain the change, select an applicable test option, answer the compatibility and documentation questions,… Add a brief explanation of the Go version upgrade. Select the applicable test option, such as No code, and complete the compatibility and documentation questions. Set the release note to None if no release note is required.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: upgrading Go to version 1.25.14. The cherry-pick reference does not prevent the title from being specific.
Linked Issues check ✅ Passed Issue #12868 requires an upgrade to Go 1.25.14. The pull request updates the root module, four additional Go modules, and the integration-test Dockerfile from Go 1.25.12 to Go 1.25.14. The changes imp…
Out of Scope Changes check ✅ Passed The reviewed changes only update Go version declarations and the Go toolchain version used by the integration-test Dockerfile. These changes directly support issue #12868. No unrelated source, depende…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Description check

Explanation

The description includes the required issue reference and template headings, but it does not explain the change, select an applicable test option, answer the compatibility and documentation questions, or provide a release note or None.

  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.13.2)

level=error msg="Running error: context loading failed: no go files to analyze: running go mod tidy may solve the problem"


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the Go trail,
The newer toolchain fills the pail.
Modules hop to versions bright,
Docker builds with tools just right,
All paths align by morning light.

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Sep 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release-8.5@66c1d4d). Learn more about missing BASE report.

Additional details and impacted files
Components Coverage Δ
cdc 57.6085% <0.0000%> (?)
dm 49.5211% <0.0000%> (?)
engine 50.7167% <0.0000%> (?)
Flag Coverage Δ
cdc 57.6085% <ø> (?)
unit 53.6235% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@@               Coverage Diff                @@
##             release-8.5     #12869   +/-   ##
================================================
  Coverage               ?   53.6235%           
================================================
  Files                  ?       1007           
  Lines                  ?     138512           
  Branches               ?          0           
================================================
  Hits                   ?      74275           
  Misses                 ?      58689           
  Partials               ?       5548           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

/test pull-dm-integration-test

@lidezhu

lidezhu commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

/test pull-cdc-integration-pulsar-test

@ti-chi-bot ti-chi-bot Bot added cherry-pick-approved Cherry pick PR approved by release team. and removed do-not-merge/cherry-pick-not-approved labels Sep 23, 2026
@ti-chi-bot

ti-chi-bot Bot commented Sep 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lidezhu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot Bot added the approved label Sep 23, 2026
@ti-chi-bot
ti-chi-bot Bot merged commit 5b6aff7 into pingcap:release-8.5 Sep 23, 2026
28 checks passed
@ti-chi-bot
ti-chi-bot Bot deleted the cherry-pick-12867-to-release-8.5 branch September 23, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants