Repository navigation
Conversation
schloerke
changed the title
Contributor
Coverage report
Test suite run success342 tests passing in 20 suites. Report generated by 🧪jest coverage report action from 4abb10e |
A dependency spelled `jupyterlab_widgets` was written to the lockfile under that key, but Pyodide looks packages up by their canonical name (`jupyterlab-widgets`), so the app failed to load it. Canonicalize names where they become lockfile keys and in the "already in Pyodide" check. Fixes #233
schloerke
force-pushed
the
schloerke/233-canonical-lock-names
branch
from
November 10, 2026 03:38
9706867 to
8b6fb44
Compare
…d packages by PEP 503 name A dependency is now keyed by its PEP 503 name, so building its import name from that key would turn ruamel.yaml into ruamel_yaml. Use the name PyPI reports instead. AVOID_DEPEND_PACKAGES is checked against the PEP 503 name, so a package that spells its name differently is still dropped.
schloerke
marked this pull request as ready for review
November 10, 2026 19:06
schloerke
marked this pull request as draft
November 10, 2026 19:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes posit-dev/shinylive#233.
A full lockfile regen (
make update_packages_lock) wrote each dependency under the name its parent used. ipywidgets 8.1.8 spells its dependencyjupyterlab_widgets, but Pyodide looks packages up by their canonical name (jupyterlab-widgets), so apps that use shinywidgets failed withNo known package with name 'jupyterlab_widgets'.scripts/pyodide_packages.pynow usespackaging.utils.canonicalize_namefor:shinylive_lock.jsonAVOID_DEPEND_PACKAGEScheck, so a package that spells its name differently is still droppedA package's import name now comes from the name PyPI reports, not from the lookup key. Built from the canonical key,
ruamel.yamlwould have becomeruamel_yaml. Every package in the current lock gets the same import names as before.Wheel filenames and URLs are unchanged; only the lookup keys are canonical.
This PR changes only the script. posit-dev/shinylive#263, stacked on top, regenerates the lock with it.