Repository navigation
Conversation
Contributor
Coverage report
Test suite run success342 tests passing in 20 suites. Report generated by 🧪jest coverage report action from 098095f |
This was referenced Nov 9, 2026
schloerke
force-pushed
the
schloerke/254-investigation-v2
branch
from
November 10, 2026 03:38
0dd06f2 to
a89cd02
Compare
Pyodide 314 ships Python 3.14, pydantic 2.12.5 and orjson 3.11.8, so shinychat can move to 0.7.x. The lockfile is regenerated with the #233 fix, so the pure-Python pins catch up with PyPI too. - toJs() now turns dicts into plain objects, which Object.fromEntries() can't take. Pass `dict_converter: Object.fromEntries` instead. - Pyodide's own starlette lists no dependencies but imports anyio. Add it through EXTRA_DEPENDENCIES. - Pyodide's altair 6.0.0 sends NaN from pandas 3 string columns as invalid JSON. Take altair 6.3.0 from PyPI, and let our lockfile replace a Pyodide package (the check meant to stop this never ran). - Set JOBLIB_MULTIPROCESSING=0. joblib now finds `multiprocessing` and warns that it will run in serial mode. - plotnine 0.15 turns the colour "#666" into the invalid "#666FF"; use "#666666" in the plot_interact_exclude example. - Pyodide 0.28 dropped `info.version` from pyodide-lock.json, so compare the whole `info` block to tell when it changed. - Skip the new `*-tests.zip` files when unpacking Pyodide. - The test servers queue more connections. Pyodide now asks for every wheel at once, and macOS resets anything past `http.server`'s queue of 5, so packages failed to load at random. Closes #254
…son by shiny pyodide-lock.json's info block no longer has a Pyodide version, and what it has is the same across patch releases, so comparing it misses an upgrade such as 314.0.6 to 314.0.7. A lock without shiny in it is always newly unpacked. Both test servers now come from tests/static_server.py.
…cking, and stop overwriting a clean saved Pyodide lock - Python 3.14 has ExceptionGroup built in, so anyio no longer needs exceptiongroup. - update_packages_lock and update_packages_lock_local read the local wheels in packages/ and expect one per package. They now depend on those wheels, whose rules remove older copies, so a leftover cp312 libsass wheel no longer breaks them. - Remove the libsass wheel rule's dependency on itself. - orig_pyodide_lock no longer copies an unreadable pyodide-lock.json over the saved original.
schloerke
marked this pull request as ready for review
November 10, 2026 19:06
schloerke
force-pushed
the
schloerke/254-investigation-v2
branch
from
November 10, 2026 19:06
a89cd02 to
098095f
Compare
schloerke
marked this pull request as draft
November 10, 2026 19:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes posit-dev/shinylive#254. Stacked on posit-dev/shinylive#262.
The libsass wheel for Pyodide 314 is built and published by gadenbuie/libsass-python#1.
Pyodide 314 runs Python 3.14 and ships pydantic 2.12.5 and orjson 3.11.8. That lets shinychat move to 0.7.2 (it needs pydantic ≥ 2.11) and brings orjson past the version shiny asks for. I chose 314 over 0.29 to skip a second upgrade later. It brings pandas 3.0; every Python example works with it.
Lockfile
Regenerated with the fix from posit-dev/shinylive#262. Notable moves: shinychat 0.6.1 → 0.7.2, plotly 5.23 → 7.1, plotnine 0.14 → 0.15, markdown-it-py 3 → 4, black 24 → 26. starlette, anyio, sniffio, platformdirs and narwhals now come from Pyodide itself. python-multipart, tenacity, pypng, uc-micro-py, appdirs and zipp drop out because nothing needs them anymore.
Changes needed by the upgrade
toJs()returns plain objects for dicts (Pyodide 0.29). The HTTP and websocket bridges passed the result toObject.fromEntries(), which would have broken every request. They now passdict_converter: Object.fromEntries, asprocessReturnValue()already does.EXTRA_DEPENDENCIES.shinylive_requirements.jsonnow takes altair from PyPI. posit-dev/shinylive#270 already lets the lockfile replace a Pyodide package.multiprocessingand warns that it will "operate in serial mode". We setJOBLIB_MULTIPROCESSING=0, which turns this off quietly.color="#666"into the invalid#666FF. This is a plotnine bug, not a Pyodide one: plotnine 0.15.9 with mizani 0.14.6 fails the same way outside Pyodide, with pandas 2 or 3. The old lock had plotnine 0.14.5, so user apps that use 3-digit hex colors with plotnine will break after this upgrade. Theplot_interact_excludeexample now uses#666666.pyodide-lock.jsondroppedinfo.version(0.28), and the rest of itsinfoblock is the same across patch releases.orig_pyodide_lock()now treats apyodide-lock.jsonwithoutshinyin it as freshly unpacked; this assumes Pyodide never ships shiny. Apyodide-lock.jsonit cannot read now raises an error instead of overwriting the saved original.exceptiongroupthroughEXTRA_DEPENDENCIES; Python 3.11+ hasExceptionGroupbuilt in.update_packages_lockandupdate_packages_lock_localread the wheels inpackages/and expect one per package. They now depend on those wheels, whose rules remove older copies, so a leftovercp312libsass wheel in an existing checkout no longer breaks them. The libsass wheel rule no longer depends on itself.*-tests.zipfiles; they're skipped like the old*test*.tarones.create_typeshed.pytargets Python 3.14.src/pyodide/is the usual copy frommake pyodide_js.Test servers
Pyodide 314 asks for every wheel an app needs at the same time.
http.serverkeeps only 5 connections waiting to be accepted, and macOS resets the others withERR_CONNECTION_RESET. As a result, packages failed to load at random in the example tests. Both test servers now come fromtests/static_server.py, which queues 128 connections. Users who serve an export withpython -m http.serveron macOS may hit the same thing.