Skip to content

fix: Clean up problems found while writing the memory bank - #270

Merged
schloerke merged 1 commit into
schloerke/memory-bank-docsfrom
schloerke/memory-bank-fixes
Nov 2, 2026
Merged

schloerke merged 1 commit into
schloerke/memory-bank-docsfrom
schloerke/memory-bank-fixes

Conversation

@schloerke

@schloerke schloerke commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the four problems listed in posit-dev/shinylive#269, and updates the memory-bank documents that described them.

  • Dead Quarto targets. quarto/ was removed in 3ecdebc, but make quarto, make quartoserve, make clean, and README.md still pointed to it. Those targets and README sections are removed.
  • Unused relPath. runExportedApp() accepted relPath and never used it. It is removed from the function and from export_template/index.html. The template is part of the same bundle, so an export always pairs a template with its own shinylive.js.
  • Warning that never fired. runApp() checked for unknown options with propertyOfAppOptions, which returns its input, so the check always passed. Making it work would warn on every Quarto block, because run-python-blocks.ts passes components and standalone through. The check is removed.
  • "Already in Pyodide" check. update_pyodide_pyodide_lock_json tested name in pyodide_packages, which looks at the top-level keys (info, packages), so it never matched. Fixing it to raise, as written, would break make all: altair, anyio, narwhals, and sniffio are in both lock files today. One of them, anyio, is pinned lower than Pyodide 0.27.7's (4.4.0 vs 4.9.0). Build output is unchanged; the check now prints <name> (replaces Pyodide's <version>) for each package that overrides Pyodide's copy, so the overrides show up in the make all log.

@schloerke
schloerke added this pull request to stack #268 November 2, 2026 20:14
@schloerke schloerke changed the title fix: Remove dead quarto targets, unused relPath, and dead unused-args warning; report Pyodide package overrides fix: Clean up problems found while writing the memory bank Nov 2, 2026
@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Unit tests only — the pure-logic modules in src/. The React components, hooks, engine proxies and service worker are covered by the pytest + Playwright suites in tests/, which are not measured here.

Coverage report

St.❔
Category Percentage Covered / Total
🟢 Statements 100% 1994/1994
🟢 Branches 100% 400/400
🟢 Functions 100% 96/96
🟢 Lines 100% 1994/1994

Test suite run success

342 tests passing in 20 suites.

Report generated by 🧪jest coverage report action from e5e50b3

@schloerke
schloerke removed this pull request from stack #268 November 2, 2026 21:36
@schloerke
schloerke added this pull request to stack #272 November 2, 2026 21:37
@schloerke
schloerke merged commit 62714e3 into main Nov 2, 2026
19 checks passed
@schloerke
schloerke deleted the schloerke/memory-bank-fixes branch November 2, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant