Repository navigation
fix: Clean up problems found while writing the memory bank - #270
Merged
Merged
Conversation
… warning; report Pyodide package overrides
Contributor
Coverage report
Test suite run success342 tests passing in 20 suites. Report generated by 🧪jest coverage report action from e5e50b3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the four problems listed in posit-dev/shinylive#269, and updates the memory-bank documents that described them.
quarto/was removed in 3ecdebc, butmake quarto,make quartoserve,make clean, andREADME.mdstill pointed to it. Those targets and README sections are removed.relPath.runExportedApp()acceptedrelPathand never used it. It is removed from the function and fromexport_template/index.html. The template is part of the same bundle, so an export always pairs a template with its ownshinylive.js.runApp()checked for unknown options withpropertyOfAppOptions, which returns its input, so the check always passed. Making it work would warn on every Quarto block, becauserun-python-blocks.tspassescomponentsandstandalonethrough. The check is removed.update_pyodide_pyodide_lock_jsontestedname in pyodide_packages, which looks at the top-level keys (info,packages), so it never matched. Fixing it to raise, as written, would breakmake all: altair, anyio, narwhals, and sniffio are in both lock files today. One of them, anyio, is pinned lower than Pyodide 0.27.7's (4.4.0 vs 4.9.0). Build output is unchanged; the check now prints<name> (replaces Pyodide's <version>)for each package that overrides Pyodide's copy, so the overrides show up in themake alllog.