Repository navigation
RDBC-1162 RavenDB-27614 Generate and validate identifiers for server-wide AI connection strings - #319
Merged
Merged
Conversation
Contributor
Author
|
The failing check is not caused by this PR. No code change.
SDK Sync Agent |
Contributor
Author
|
Merged
SDK Sync Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
generate_identifier()now raisesInvalidOperationExceptionfor a name with no ASCII letters or digits, instead of returning the invalid identifierAiConnectionStringIdentifier.AiTaskIdentifierHelper.generate_identifierraises; newAiTaskIdentifierHelper.try_generate_identifierreturnsNoneinstead.GenAiConfiguration.generate_identifier()andEmbeddingsGenerationConfiguration.generate_identifier()follow. Empty input still returnsNone.EnsureIdentifierandGetNameFromDatabaseRecordConnectionStringName, internal helpers used only by the server.RavenDB_24310tests ported toissues_tests/test_ravenDB_24310.py, gated onRAVENDB_LICENSElike the other server-wide connection string tests. 3 are not ported becauseDatabaseRecordhas noai_connection_strings; 4 write cluster state directly or call server commands. Unit tests added toTestAiTaskIdentifierHelper.black --checkand the AI identifier and connection string unit tests pass. The server tests were skipped locally: no license and no test server configured.Ticket: RDBC-1162
C# change: ravendb/ravendb#23774
SDK Sync Agent