Repository navigation
RDBC-1151 RavenDB-24824 Add per-call output schema override and string output for AI conversations - #318
Merged
Conversation
… no-args tools to AI conversations
poissoncorp
marked this pull request as ready for review
October 7, 2026 12:24
Contributor
Author
|
The failing check is not caused by this PR. No code change.
A rerun of the failed job should pass. If it fails again, the secured test server setup in CI needs a look. SDK Sync Agent |
This was referenced Oct 8, 2026
Contributor
Author
|
please fix failing/flaky test as well and rebase other PRs after merge |
The worker waits 5 seconds before it reconnects, so a failed first connection attempt made the 4 second wait time out.
Contributor
Author
|
Fixed the flaky secured subscription tests in 19fd21f.
SDK Sync Agent |
Contributor
Author
|
fix failing test |
…st_more_like_this
Contributor
Author
|
Fixed the failing
SDK Sync Agent |
This was referenced Oct 22, 2026
RDBC-1162 RavenDB-27614 Generate and validate identifiers for server-wide AI connection strings
#319
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI conversations can now override the output schema for one turn with a schema string or a sample object, get plain text answers with
run_text()andstream_text(), and register tools that take no parameters.run_with_schemaandstream_with_schemaaccept anAiOutputOptions, a JSON schema string or a sample object (dict or entity). Newrun_text(),stream_text(on_chunk),handle_no_args()andreceive_no_args()onAiConversation.RunConversationCommandstreams wheneverstream_property_pathis notNone, so a no-schema turn can stream with an empty path, as in C#.AiOutputOptions,OutputOptionsin the request body and stringResponseparsing.no_schemaand schema conflict is already rejected byAiOutputOptions). Sync and async overload pairs and expression-based paths are C#-specific.test_ai_output_options.pygains schema shorthand, raw text and no-args tool tests with mocked conversation calls, adapted fromRavenDB_24824. TheRavenDB_24824tests that need a live OpenAI connection are not ported.black --check .passed;test_ai_output_optionspassed (31);ai_agent_testspassed, and the tests that need a server run only in CI.Decision needed
Python has no overloading, and
run()already means "use the agent's schema", so the C# overloads need names.run_text(),stream_text(),handle_no_args(),receive_no_args()(recommended, this PR): explicit, and existing signatures stay the same.output_optionsargument onrun()andstream(), as in the Node.js client.handle()andreceive()check the handler's parameter count instead of new methods.Existing behavior that this PR does not change:
add_action_responsekeeps only string results, so a handler that returns a dict sends no content, while C# serializes it to JSON.Ticket: RDBC-1151
C# change: ravendb/ravendb#22632
SDK Sync Agent