Repository navigation
RDBC-1156 RavenDB-22083 Report a proper IndexCompilationException for a C# index whose outer from clause does not enumerate the documents source - #316
Merged
Conversation
poissoncorp
marked this pull request as ready for review
October 7, 2026 12:24
…d name, expect the server message for a query-syntax map
Contributor
Author
|
Fixed the failing
Checks: black passes and the dispatch unit tests pass. The server tests run only in CI. SDK Sync Agent |
Contributor
Author
|
The failing build job is not caused by this PR.
SDK Sync Agent |
This was referenced Oct 22, 2026
Contributor
Author
Contributor
Author
|
Merged
SDK Sync Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Index compilation errors from the server now raise
IndexCompilationException, with the failingindex_definition_propertyandproblematic_text, instead of a plainRavenException.CompilationExceptionandIndexCompilationException, exported fromravendb, mapped inExceptionDispatcher, which fills both fields from the error body.AbstractIndexCreationTask.create_index_definitionraisesIndexCompilationExceptioninstead ofRuntimeError, as the C# client does.IndexDefinitionHelper.FormatLinqQuerywhole-word matching of the query source. It is C# LINQ expression tree code, and Python index maps are plain strings.test_ravenDB_22083.pywith 7 server tests fromRavenDB_22083, with the LINQ maps written as index text, and 3 dispatcher tests that need no server. The tests for LINQ parameter name substitution andAddMapForAllare C#-specific.black --check .passed; the dispatcher tests,test_exception_dispatcherandtest_commercial_limitspassed (15); the server tests run only in CI.Decision needed
The C# change itself is LINQ-only. The Python client had no
IndexCompilationException, so the server error that this ticket improves could not be told apart from other errors. Adding it is about 30 lines plus the dispatcher wiring.IndexCompilationExceptionis still aRuntimeError, so existing handlers keep working. The one visible difference increate_index_definitionis that the inner error is now in.causeinstead ofargs[1].create_index_definitionraisingRuntimeError.Ticket: RDBC-1156
C# change: ravendb/ravendb#23581
SDK Sync Agent