Repository navigation
RDBC-1141 RavenDB-25401 - Fix refusal on streaming - #314
Merged
Merged
Conversation
Contributor
Author
|
The failing check is not caused by this PR. No code change.
A rerun of the failed job should pass. If it fails again, the secured test server setup in CI needs a look. SDK Sync Agent |
This was referenced Oct 8, 2026
Contributor
Author
|
The failing build job is not caused by this PR.
SDK Sync Agent |
Contributor
Author
Contributor
Author
|
Merged
SDK Sync Agent |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A streamed AI conversation now raises the server error, such as a model refusal, when it arrives after streaming has started, instead of returning it as the result.
RunConversationCommand.process_responsechecks the final streamed line for a non-emptyTypeand raises the matching exception throughExceptionDispatcher(for exampleRefusedToAnswerException).AiAgentErrorsandChatCompletionClientTestsare server-side.test_ai_conversation_streaming_errors.pyfeeds a streamed response to the command and covers an error payload, a refusal payload and a normal result. The C#RavenDB_25401tests use a server testing hook and a live AI provider, so their assertions are covered by these unit tests instead.black --check .passed; the new tests passed (3);ai_agent_testspassed, and the tests that need a server run only in CI.Ticket: RDBC-1141
C# change: ravendb/ravendb#22997
SDK Sync Agent