Skip to content

RDBC-1140 RavenDB-27181 : GPT-5.6 models unusable with AI agents - tools rejected on /v1/chat/completions - #315

Merged
poissoncorp merged 2 commits into
ravendb:v7.2from
poissoncorp:sdk-sync/RDBC-1140
Oct 22, 2026
Merged

poissoncorp merged 2 commits into
ravendb:v7.2from
poissoncorp:sdk-sync/RDBC-1140

Conversation

@poissoncorp

@poissoncorp poissoncorp commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

OpenAiSettings now has a reasoning_effort string setting, sent to OpenAI as ReasoningEffort to control the reasoning depth of models such as the GPT-5 family.

  • Changed: OpenAiSettings takes an optional reasoning_effort (last keyword argument). to_json writes ReasoningEffort only when it is set and not blank. from_json reads it and treats a non-string value as not set.
  • Not ported: the obsolete OpenAiReasoningEffort enum and ToReasoningEffort exist in C# only to migrate code written against the enum. The GPT-5.4+ "none" handling is done by the server.
  • Tests: new test_open_ai_reasoning_effort.py with serialization tests and a connection string round trip (from RavenDB_27181.ReasoningEffortSurvivesAConnectionStringRoundTrip). The other RavenDB_27181 tests need a live OpenAI integration or server internals.
  • Checks: black --check . passed; the serialization tests and test_ai_agent_configuration passed (18); the round trip test needs a server and runs only in CI.

Decision needed

The Python client had no reasoning effort setting, so this adds a new public field instead of changing a type.

  1. Merge as is (recommended): it matches the current C# API, a free-form string, and is left out of the JSON when not set.
  2. Also add a Python enum of typical values. The C# client now marks its enum obsolete, so this adds API that the other clients move away from.
  3. Do not merge. The fix for the affected models is on the server, so the client works without this setting.

Ticket: RDBC-1140
C# change: ravendb/ravendb#23437

SDK Sync Agent

@poissoncorp poissoncorp added the sdk-sync Port of C# client changes from an SDK sync task label Oct 7, 2026
@poissoncorp
poissoncorp marked this pull request as ready for review October 7, 2026 12:24
@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing check is not caused by this PR. No code change.

A rerun of the failed job should pass. If it fails again, the secured test server setup in CI needs a look.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing build job is not caused by this PR.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing check is not caused by this PR. No code change.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

Merged v7.2 into this branch (d7602c9) to pick up the test fixes from #318. No change to the code of this PR.

  • test_secured_subscription_basic: the tests now wait 15 seconds for a batch instead of 4, longer than the 5-second reconnect delay of the worker.
  • black --check passes locally. The tests need a server and run only in CI.

SDK Sync Agent

@poissoncorp
poissoncorp merged commit 0aaddf0 into ravendb:v7.2 Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-sync Port of C# client changes from an SDK sync task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant