Skip to content

RDBC-1148 Merge release/quill into ravendb/v7.2 - #313

Merged
poissoncorp merged 2 commits into
ravendb:v7.2from
poissoncorp:sdk-sync/RDBC-1148
Oct 22, 2026
Merged

poissoncorp merged 2 commits into
ravendb:v7.2from
poissoncorp:sdk-sync/RDBC-1148

Conversation

@poissoncorp

@poissoncorp poissoncorp commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

AiConversationMessagesResult now has created_at: the time the AI conversation was created, read from the CreatedAt field the server returns.

  • Changed: AiConversationMessagesResult takes an optional created_at (last keyword argument, so existing positional calls keep working), and reads and writes it in from_json and to_json.
  • Not ported: Quill constants, the CDC dry run request, result and operation, and JSON deserializer entries are internal to the C# client. The CDC join column validation runs on the server when a configuration is saved. LimitType.QUILL is already present.
  • Tests: two unit tests in test_ai_conversation_messages.py cover the value when present and when missing. The C# change has no client test for this field.
  • Checks: black --check . passed; test_ai_conversation_messages passed (27 tests); ai_agent_tests passed, and the tests that need a server run only in CI.

Ticket: RDBC-1148
C# change: ravendb/ravendb#23585

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing check is not caused by this PR. No code change.

A rerun of the failed job should pass. If it fails again, the secured test server setup in CI needs a look.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing build job is not caused by this PR.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

The failing check is not caused by this PR. No code change.

SDK Sync Agent

@poissoncorp

Copy link
Copy Markdown
Contributor Author

Merged v7.2 into this branch (7230c8c) to pick up the test fix from #318. No change to the code of this PR.

  • test_secured_subscription_basic: the tests now wait 15 seconds for a batch instead of 4, longer than the 5-second reconnect delay of the worker.
  • black --check passes locally. The tests need a server and run only in CI.

SDK Sync Agent

@poissoncorp
poissoncorp merged commit b1e8985 into ravendb:v7.2 Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

sdk-sync Port of C# client changes from an SDK sync task

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant