Skip to content

[CodeQuality] Wrap assign on right side of binary op in LogicalToBooleanRector #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jul 6, 2026
+21 −0
Merged

[CodeQuality] Wrap assign on right side of binary op in LogicalToBooleanRector #8151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions ...ests/CodeQuality/Rector/LogicalAnd/LogicalToBooleanRector/Fixture/assign_on_right.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
<?php

true and $x = 42 and false;

var_dump($x);

?>
-----
<?php

true && ($x = 42) && false;

var_dump($x);

?>
6 changes: 6 additions & 0 deletions src/PhpParser/Printer/BetterStandardPrinter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -478,6 +478,12 @@ private function wrapBinaryOpWithBrackets(Node $node): void
$node->left->setAttribute(AttributeKey::ORIGINAL_NODE, null);
}

if ($node->right instanceof Assign
&& $this->origTokens instanceof TokenStream
&& ! $this->origTokens->haveParens($node->right->getStartTokenPos(), $node->right->getEndTokenPos())) {
$node->right->setAttribute(AttributeKey::ORIGINAL_NODE, null);
}

if ($node->left instanceof BinaryOp &&
$node->left->getAttribute(AttributeKey::ORIGINAL_NODE) instanceof Node) {
$node->left->setAttribute(AttributeKey::ORIGINAL_NODE, null);
Expand Down
Loading