Repository navigation
ci: pull requests compile once - #133
Merged
Merged
Conversation
Pull request CI now runs the typecheck (bun turbo typecheck) and nothing else. core (linux) and httpapi (linux) are dispatch-only and skip on pull requests, which still reports the required check names as passing. engine-client runs clippy without --all-targets on pull requests; fmt, all-target clippy and cargo test run by hand (workflow_dispatch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's done
Pull request CI compiles once. The release build compiles again on every target.
typecheck(bun turbo typecheck)core (linux)(core tests, generated checks)httpapi (linux)(HttpApi gates)engine-client(fmt + clippy --all-targets + cargo test)testworkflow wall timeSeconds-long checks kept:
changes,unit (linux)aggregator,gitflow,tag-hygiene,PR policy.What's not done
No branch protection or ruleset change. No test file or script deleted. Release, publish and container workflows untouched.
What to review
Required checks on develop and main, all still reported:
typecheck(runs)core (linux)(skipped on PRs = passing)httpapi (linux)(skipped on PRs = passing)unit (linux)(runs, aggregates)gitflow / branch name follows the convention(runs)Intentions
Everything removed from PRs still runs by hand: Actions -> test -> Run workflow (core, httpapi, engine shards, Windows legs) and Actions -> engine-client -> Run workflow (fmt, all-target clippy, cargo test).