Skip to content

ci: pull requests compile once #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
its-janghoon merged 1 commit into from
Oct 21, 2026
Merged

ci: pull requests compile once #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/engine-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ on:
paths:
- "crates/engine-client/**"
- ".github/workflows/engine-client.yml"
# By hand: fmt and tests too. A pull request only compiles (clippy, no test targets).
workflow_dispatch:

permissions:
contents: read
Expand All @@ -27,6 +29,11 @@ jobs:
- uses: Swatinem/rust-cache@v2
with:
workspaces: crates/engine-client
- run: cargo fmt --all -- --check
- run: cargo clippy --all-targets --locked -- -D warnings
- run: cargo test --locked
- if: github.event_name != 'pull_request'
run: cargo fmt --all -- --check
- if: github.event_name == 'pull_request'
run: cargo clippy --locked -- -D warnings
- if: github.event_name != 'pull_request'
run: cargo clippy --all-targets --locked -- -D warnings
- if: github.event_name != 'pull_request'
run: cargo test --locked
13 changes: 8 additions & 5 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: test

on:
# Pull requests run ONE fast linux path: typecheck, core unit tests, the HttpApi gates.
# The long engine suite and the Windows legs run only by hand (Actions -> test -> Run
# workflow), where `changes` always reports heavy=true and every job below runs.
# Pull requests compile once: the typecheck, nothing more. The release build compiles
# again on every target. Core tests, the HttpApi gates, the engine suite and the Windows
# legs run only by hand (Actions -> test -> Run workflow), where `changes` always
# reports heavy=true and every job below runs.
workflow_dispatch:
# Pull requests only. A merge to `develop` or `main` is a pull request that already
# passed, so running again on push would repeat the same checks.
Expand Down Expand Up @@ -100,10 +101,11 @@ jobs:
# keeps combined tsgo RSS near 6 GB.
run: bun turbo typecheck --concurrency=2

# Dispatch only. Required check: skipped on a pull request, which counts as passing.
core:
name: core (linux)
needs: changes
if: needs.changes.outputs.heavy == 'true'
if: needs.changes.outputs.heavy == 'true' && github.event_name != 'pull_request'
runs-on: ubuntu-latest
timeout-minutes: 20
defaults:
Expand Down Expand Up @@ -146,10 +148,11 @@ jobs:
working-directory: packages/redrob
run: bun run check:generated

# Dispatch only. Required check: skipped on a pull request, which counts as passing.
httpapi:
name: httpapi (linux)
needs: changes
if: needs.changes.outputs.heavy == 'true'
if: needs.changes.outputs.heavy == 'true' && github.event_name != 'pull_request'
runs-on: ubuntu-latest
timeout-minutes: 20
defaults:
Expand Down
Loading