Repository navigation
StepDialog, the shared stepped modal - #524
Merged
Merged
Conversation
jhodapp
marked this pull request as ready for review
November 3, 2026 21:49
Contributor
[Low impact] The PR adds a dialog component but does not mount it in an active screen. The PR appears safe to merge with a non-blocking issue: resizing clears values held inside the step body.
|
jhodapp
force-pushed
the
feat/scheduling-controls
branch
from
November 3, 2026 23:28
095eebe to
b8c2930
Compare
jhodapp
force-pushed
the
feat/step-dialog
branch
from
November 3, 2026 23:28
466edae to
995de21
Compare
jhodapp
force-pushed
the
feat/scheduling-controls
branch
from
November 4, 2026 04:53
b8c2930 to
46028ad
Compare
jhodapp
force-pushed
the
feat/step-dialog
branch
from
November 4, 2026 04:53
995de21 to
2da7972
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Third of five PRs for the stepped "New session" dialog. Adds
StepDialog, the shared shell every stepped modal in the redesign uses (New session first). Not mounted anywhere yet. Stacked on #523.Changes
ui/step-dialog.tsx: on Radix Dialog parts. Desktop (≥900px): fixed 860 × 560/520 two-pane modal, 300px white rail (title, optional header, step list with current row and done checks, optional footer), well pane with the step title, a body that's the only scroll region, and a pinned footer (confirm pill or hint, "n of m", 48px prev/next circles). Below 900px: full-screen step view with a 56px top bar ("New session · 2 of 3"), the rail content in the body, and a sticky footer (back circle, Next or confirm pill).bg-scrim,shadow-modal,rail-current,rail-border, light and dark.Screenshots / Videos Showing UI Changes (if applicable)
None yet; the New session dialog PR mounts it.
Testing Strategy
tscand lint clean.