Skip to content

StepDialog, the shared stepped modal - #524

Merged
jhodapp merged 2 commits into
feat/scheduling-controlsfrom
feat/step-dialog
Nov 4, 2026
Merged

jhodapp merged 2 commits into
feat/scheduling-controlsfrom
feat/step-dialog

Conversation

@jhodapp

@jhodapp jhodapp commented Nov 3, 2026

Copy link
Copy Markdown
Member

Description

Third of five PRs for the stepped "New session" dialog. Adds StepDialog, the shared shell every stepped modal in the redesign uses (New session first). Not mounted anywhere yet. Stacked on #523.

Changes

  • ui/step-dialog.tsx: on Radix Dialog parts. Desktop (≥900px): fixed 860 × 560/520 two-pane modal, 300px white rail (title, optional header, step list with current row and done checks, optional footer), well pane with the step title, a body that's the only scroll region, and a pinned footer (confirm pill or hint, "n of m", 48px prev/next circles). Below 900px: full-screen step view with a 56px top bar ("New session · 2 of 3"), the rail content in the body, and a sticky footer (back circle, Next or confirm pill).
  • Keyboard: Esc, scrim click and × close; Enter confirms when the confirm is enabled and focus isn't in a field.
  • Tokens: bg-scrim, shadow-modal, rail-current, rail-border, light and dark.
  • Style guide: a Stepped modal entry, including the full-screen step view (closes that open item).

Screenshots / Videos Showing UI Changes (if applicable)

None yet; the New session dialog PR mounts it.

Testing Strategy

  • 18 tests written as the spec first: roles and names, rail, slots, prev/next, confirm and hint, Esc, Enter rules, both layouts. All 2626 tests pass, tsc and lint clean.

@jhodapp jhodapp changed the title feat(design): StepDialog, the shared stepped modal StepDialog, the shared stepped modal Nov 3, 2026
@jhodapp jhodapp self-assigned this Nov 3, 2026
@jhodapp jhodapp added enhancement Improves existing functionality or feature feature work Specifically implementing a new feature labels Nov 3, 2026
@jhodapp jhodapp added this to the 1.0.0-beta4 milestone Nov 3, 2026
@jhodapp jhodapp moved this to 🏗 In progress in Refactor Coaching Platform Nov 3, 2026
@jhodapp jhodapp moved this from 🏗 In progress to Review in Refactor Coaching Platform Nov 3, 2026
@jhodapp
jhodapp marked this pull request as ready for review November 3, 2026 21:49
@greptile-apps

greptile-apps Bot commented Nov 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The PR adds a dialog component but does not mount it in an active screen.

The PR appears safe to merge with a non-blocking issue: resizing clears values held inside the step body.

Fix All in Claude CodeFindings

  1. P2 Resizing clears the search ▶

Summary

Adds StepDialog, a shared desktop and mobile stepped modal, with navigation, confirmation, keyboard shortcuts, theme tokens, and 18 tests.

  • Stepped workflows use a shared dialog that changes with screen width.

Reviews (1) · Last reviewed commit: "feat(design): add StepDialog, the shared..." · Reviewed by Greptile

Comment thread src/components/ui/step-dialog.tsx Resolved
@jhodapp
jhodapp force-pushed the feat/scheduling-controls branch from 095eebe to b8c2930 Compare November 3, 2026 23:28
@jhodapp
jhodapp force-pushed the feat/scheduling-controls branch from b8c2930 to 46028ad Compare November 4, 2026 04:53
@jhodapp
jhodapp merged commit b2396e8 into feat/scheduling-controls Nov 4, 2026
@jhodapp
jhodapp deleted the feat/step-dialog branch November 4, 2026 05:35
@github-project-automation github-project-automation Bot moved this from Review to ✅ Done in Refactor Coaching Platform Nov 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improves existing functionality or feature feature work Specifically implementing a new feature

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant