[jhodapp]

Description

Fourth of five PRs for the stepped "New session" dialog. Schedule mode: Add New › Coaching session and the empty Upcoming card's "Schedule a coaching session" now open the new dialog. Its steps are Who, When and Repeat, plus Resolve overlap when the chosen time clashes. It replaces the old "Create New Coaching Session" form. Stacked on #524.

Changes

• Dialog: a newSessionDialogStore with its host mounted once in Providers. The dialog can open from any page, and every open starts fresh. A useNewSessionDialog hook drives the presentational step components, built on New session dialog step controls #523's controls and StepDialog, the shared stepped modal #524's StepDialog.
• Who: shows the people you coach, ordered by activity, with their usual slot or last session. Inactive people stay behind "Show everyone".
• When: picking a person prefills their usual day and time if that slot is free. Busy days get dots, with a day tooltip. Up to five free time suggestions. A clash shows an overlap note with the next free time.
• Repeat: Doesn't repeat, Weekly, Every 2 weeks or Monthly; weekdays; ends after N sessions or on a date.
• Resolve overlap: move the other session to a free slot in that week, or keep both. If the move fails, the new session is kept and an error toast says the other one didn't move.
• Submit: creates a single session or a series, then moves the other session if one was chosen. Shows "Scheduled · …" toasts. Stays open with your choices on a retryable error.
• Pure logic: lib/schedule-draft.ts. Suggested times now count a coach's start time only once it's been used twice.
• Removed:
  • The create half of coaching-session-form.tsx (the coachee Select and the recurrence section). It's update-only now, for Reschedule until the next PR.
  • sessionCreatedMessage and seriesCreatedMessage.
• StepDialog: a rail row can be current and done at once (as in the mockup). Opening the dialog focuses the dialog itself, not ×.
• Docs:
  • New docs/test-plans/new_session_dialog_manual_testing.md.
  • Design-system plan Case E5 updated.
  • The e2e create flow now uses the new dialog.

Screenshots / Videos Showing UI Changes (if applicable)

Useful: each step on desktop (Who, When with an overlap, Repeat Weekly, Resolve overlap), and When at 375px.

Testing Strategy

• Specs written first:
  • The whole dialog flow: who's listed, prefill, overlap, resolve, payloads, toasts, errors, double click, fresh state per open.
  • The pure draft logic and the store.
• All 2692 tests pass; tsc and lint are clean.
• Real browser against a local backend:
  • Geometry stays fixed across steps, short windows and 375px.
  • Each step matches the mockups.
  • Tooltips aren't clipped.
  • Sessions created through the Jim-coaches-Jim relationship landed with the right payload and toast, and showed on the dashboard without a reload.
  • The e2e spec's new dialog steps, replayed on the current data, schedule successfully.
  • A live overlap: the new session was created first, then the overlapped session was moved (same id). The toast ended "· Caleb moves to Wed 4, 4:00 PM", and both showed on the dashboard without a reload.
• Manual: run docs/test-plans/new_session_dialog_manual_testing.md.

Concerns

• The full multi-org-live.spec.ts wasn't run, since it needs a freshly seeded database. Its changed steps were replayed by hand.
• The overlap check covers a series' first session only (a known v1 limit, Case E7).
• At 320px, calendar days are 41px circles; seven columns can't fit 44.

[greptile-apps]

Confidence Score: 3/5

[Medium impact] The changes affect how coaches schedule and reschedule sessions.

Fix the calendar-read and multiple-overlap paths before merging.

Findings

1.  Unread calendars look free ▶
2.  A second overlap stays hidden ▶
3.  Earlier saves close newer drafts ▶

Summary

Replaces session creation with a shared New session dialog.

• Coaches schedule sessions through a guided New session dialog.
• The old session form now only changes existing sessions.
• The step dialog shows progress while keeping the current step clear.

The supplied description explicitly acknowledges checking only the first occurrence of a series. This remains excluded as a known limit; the supplied author login is jhodapp.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Open dialog] --> B[Choose person]
  B --> C[Choose date and time]
  C --> D[Choose repeat settings]
  D --> E{Overlap found?}
  E -->|Yes| F[Move other session or keep both]
  E -->|No| G[Create session or series]
  F --> G
  G --> H{Move selected?}
  H -->|Yes| I[Move other session]
  H -->|No| J[Refresh lists and show confirmation]
  I --> J

Loading

_{Reviews (1) · Last reviewed commit: "fix(scheduling): let clicks pass through..." · Reviewed by Greptile}

[greptile-apps]

Unread calendars look free

useScheduleData drops the busy read's loading and error state. On an uncached month, a slow or failed request returns an empty list. The dialog then offers occupied times as free and lets the coach submit without resolving the overlap. Keep availability in a loading/error state and block confirmation until the selected range has loaded successfully.

[jhodapp]

Fixed on #527 in "fix(scheduling): don't confirm against an unread calendar, a second overlap, or a loading series rule".

[greptile-apps]

A second overlap stays hidden

clashFor keeps only the first overlapping session. A long new session can overlap two existing sessions. Moving the first enables confirmation while the second still overlaps, without asking the coach to keep that overlap. Track all clashes and require a choice for each before confirming.

[jhodapp]

Fixed on #527 in "fix(scheduling): don't confirm against an unread calendar, a second overlap, or a loading series rule".