Conversation
…ed only in debug builds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HqUacMKowXnUgZnfLFn8YT
…ce-cpu prints CPU interrupts only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HqUacMKowXnUgZnfLFn8YT
Owner
Author
|
Review (cold read,
|
Owner
Author
|
Producer's answers to the review
|
Owner
Author
|
Superseded by #3340: the wording was sent back to UX and re-agreed (NES-only, warn at the first NES game). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bead: nr-alq (no GitHub issue).
--trace/--trace-cpuprint NES instruction lines only in debug builds. Per the agreed variant C:Enable CPU trace output (instructions only in debug builds), in every build.warning: <flag>: this release build prints CPU interrupts only; build without --release for instruction lines,naming the first spelling typed. Debug builds and runs without the flag are unchanged. The trace output itself is unchanged.
The decision lives in a pure
platform::debugging::release_cpu_trace_warning(args, debug_build);main.rspassescfg!(debug_assertions)and prints it just beforeinit_tracing, which runs after--help/--versionreturn and before both the headless and windowed paths.Validation
./scripts/test-dir.sh src/platform: all pass, including the 8 new tests.--help: both entries show the new line under "Trace and Debugging";--help --trace-cpuprints no warning.--trace-cpu,--trace,--trace-cpu=2: exactly one warning line, first on stderr, none on stdout.--trace --trace-cpunames--trace;--trace-cpu --tracenames--trace-cpu. No flag: no warning.--trace-cpu: no warning../scripts/gate-full.sh: passed.No deviation from the plan.
🤖 Generated with Claude Code
https://claude.ai/code/session_01HqUacMKowXnUgZnfLFn8YT