Conversation
…traced only in debug builds Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnkhMKupMHwCLcHBCKtE4W
…lling that turned it on Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnkhMKupMHwCLcHBCKtE4W
… NES game starts with --trace/--trace-cpu Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnkhMKupMHwCLcHBCKtE4W
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnkhMKupMHwCLcHBCKtE4W
|
Review (cold read, The help line and warning text match the agreed wording exactly. The flag the warning names is the one that turned the trace on.
|
…e release warning; fix architecture's debugging paths Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MnkhMKupMHwCLcHBCKtE4W
|
Answers to the review, at
No follow-up review: the change is a mechanical extraction that keeps behaviour as it was, plus doc paths. |
Bead: nr-alq (Forge refactoring; no GitHub issue). Supersedes #3336, whose wording was sent back to UX (false for SNES/GB and NES level 2) and re-agreed as option B.
What changes
--help:--traceand--trace-cpuread "Enable CPU trace output (NES instructions only in debug builds)".--trace/--trace-cpuprints, once per run, on stderr, as the run's first NES game starts (CLI or browser), before any of its trace lines:warning: <flag>: this release build prints no NES instruction lines; build without --release for themSNES / GB / GBA games get none; the spelling named is the one that turned the trace on.
platform::debugging::release_nes_trace_warning(args, debug_build)builds the text inmain;AppContextholds it;rom_loader::build_nes_console(the one load path of headless and windowed runs) takes and prints it after the cartridge parses.Validation (the plan's, all passed)
./scripts/test-dir.sh src/platform: 664 passed.--headless --frames 1, onpalette.nes:--trace-cpu→ one warning naming--trace-cpu;--trace→--trace;--trace --trace-cpu→ one line,--trace;--trace-cpu=0 --trace→--trace;--trace-cpu=0and no flag → none; nothing on stdout.--trace-cpu=2on a.sfcand a.gbROM → no warning. Debug build--trace-cpuon NES → no warning.--helpshows the agreed line on both entries;--help --trace-cpuprints no warning../scripts/gate-full.sh: passed.--trace-cpu, open an SNES game (no warning), then an NES game (one), then another NES game (none).No deviation from the plan.
🤖 Generated with Claude Code
https://claude.ai/code/session_01MnkhMKupMHwCLcHBCKtE4W