Skip to content

perf: skip unused HMR in warm timing sessions #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Sep 23, 2026
Merged

perf: skip unused HMR in warm timing sessions #197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 18 additions & 12 deletions scripts/benchmark.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -791,17 +791,21 @@ async function runDevSession(
return duration;
});
};
// Warm timing sessions only measure startup; memory sessions need HMR load.
const runHmr = cache === 'cold' || measurement === 'memory';
const hmrTimes: number[] = [];
for (let update = 0; update < 10; update++) {
const file = files[update % 2];
const marker = `benchmark-hmr-${cache}-${update}`;
hmrTimes.push(
await updateModule(
file.path,
`${file.baseline}\nconsole.log(${JSON.stringify(marker)}, Date.now());\n`,
marker,
),
);
if (runHmr) {
for (let update = 0; update < 10; update++) {
const file = files[update % 2];
const marker = `benchmark-hmr-${cache}-${update}`;
hmrTimes.push(
await updateModule(
file.path,
`${file.baseline}\nconsole.log(${JSON.stringify(marker)}, Date.now());\n`,
marker,
),
);
}
}
if (measurement === 'timing' && cache === 'cold') {
metrics.rootHmr = median(hmrTimes.filter((_, index) => index % 2 === 0));
Expand Down Expand Up @@ -831,8 +835,10 @@ async function runDevSession(
}
// Measurement is over. Restore the exact baseline while the server is
// alive, await each rebuild, then let graceful shutdown flush the cache.
for (const file of files)
await updateModule(file.path, file.baseline, file.marker);
if (runHmr) {
for (const file of files)
await updateModule(file.path, file.baseline, file.marker);
}
details = { ...details, succeeded: true };
} catch (error) {
command.error ??= String(error);
Expand Down
Loading