chore(deps): upgrade Rspress to 2.0.22 - #38
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved issues were identified, and the supplied validation passed.
Review effort: Lite
Findings: None
What changed in this PR
Upgrades the shared Rspress dependency from 2.0.19 to 2.0.22 and aligns route-related test expectations.
Changes:
- Updates the workspace catalog and lockfile.
- Adjusts Google Analytics and GitHub Pages canonical URL assertions.
- Verifies
/index.htmlcanonicalization and analytics paths.
| File | Summary |
|---|---|
pnpm-workspace.yaml |
Updates the shared Rspress version. |
pnpm-lock.yaml |
Refreshes resolved dependencies and snapshots. |
packages/rspress-plugin-google-analytics/index.spec.ts |
Updates canonical URL and analytics assertions. |
packages/rspress-plugin-gh-pages/index.spec.ts |
Updates the GitHub Pages canonical URL expectation. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the shared Rspress catalog and lockfile from 2.0.19 to 2.0.22, the npm
latestrelease verified for this upgrade.Make the affected E2E tests visit their canonical URLs directly. Explicitly enable
route.cleanUrls: truein the GitHub Pages example and keep testing/rspress-plugins/. The Google Analytics example retains the defaultcleanUrls: false; its tests visit/index.htmland verify that exactpage_path. Existing content, asset-base, multi-ID, anonymization, and page-view assertions remain intact.Validation on macOS (Node.js 24.20.0, pnpm 11.15.0):
pnpm install --frozen-lockfile --ignore-scriptspnpm buildpnpm docs:buildpnpm lintpnpm test— 13 passedpnpm e2e— 29 passed, 0 skippedLint, unit tests, and the complete E2E suite were rerun after the canonical URL and GitHub Pages configuration changes.