cg_llvm: Make the LLVM version-check bindings safe - #162710
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_codegen_llvm/src/llvm/enzyme_ffi.rs cc @ZuseZ4 |
rustbot
added
A-LLVM
rustbot
added
the
T-compiler
Collaborator
|
r? @chenyukang rustbot has assigned @chenyukang. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 13, 2026
cg_llvm: Make the LLVM version-check bindings safe - Follow-up to rust-lang#161788 --- These version-check functions should always be safe to call, so marking them `safe` avoids some unsafe blocks at call sites. There should be no change to compiler behaviour.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 13, 2026
cg_llvm: Make the LLVM version-check bindings safe - Follow-up to rust-lang#161788 --- These version-check functions should always be safe to call, so marking them `safe` avoids some unsafe blocks at call sites. There should be no change to compiler behaviour.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 13, 2026
Rollup of 5 pull requests Successful merges: - #161178 (lint ineffective #[unstable] annotations on re-exports) - #162642 (Add regression test for matching associated types on new solver) - #162665 (Add a UI regression test.) - #162710 (cg_llvm: Make the LLVM version-check bindings safe) - #162722 (Fix typo in riscv64a23-unknown-linux-gnu platform docs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 13, 2026
Rollup merge of #162710 - Zalathar:version-safe, r=chenyukang cg_llvm: Make the LLVM version-check bindings safe - Follow-up to #161788 --- These version-check functions should always be safe to call, so marking them `safe` avoids some unsafe blocks at call sites. There should be no change to compiler behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These version-check functions should always be safe to call, so marking them
safeavoids some unsafe blocks at call sites.There should be no change to compiler behaviour.