Repository navigation
Fix browser storage failures, keyboard navigation and route metadata - #137
Merged
Merged
Conversation
sbc1-code
added a commit
that referenced
this pull request
Oct 21, 2026
Close the existing release records after PR #137 production verification. Three Markdown files only; no application or workflow changes. Documentation CI passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocked browser storage and malformed saved favorites could crash the dashboard. The app now treats persistence as optional, validates saved preferences and favorites, keeps language/theme controls usable in the open document, and reports a failed favorite save without emitting success. About accurately describes the existing local rounded-coordinate storage; no new collection or transmission is added.
Keyboard navigation now moves skip-link focus into main, closes the mobile menu with Escape and returns focus, and uses a single 44px-minimum back link instead of nested link/button controls. SPA navigation synchronizes Twitter previews and removes another route’s generated schema while retaining same-route and shared schema. Full runtime schema regeneration remains separate work.
Validation on the exact approved source at 2c9c8bd, integrated locally with current main’s collector data: fresh npm ci and build PASS; 118/118 unit tests PASS; full npm test PASS with 402 desktop/mobile navigations. EN/ES checks cover blocked reads/quota, malformed preferences, successful/failed favorites, keyboard focus, route metadata, Compare expiry/recovery, sharing and feedback. The route count reflects the current snapshot’s pedestrian-route inventory; no route rule changed.
Audit gate unchanged: zero high/critical and eight moderate package entries remain. No dependency/lockfile, ads, credentials, permissions, security settings or paid-service changes. Original checkout’s 18 changed paths and newer untracked/generated local work are preserved. This is the bounded follow-up to #136, approved for publication on October 21. Production will use the existing Actions workflow after CI passes, followed by served-app verification. Limited tests do not establish complete security/accessibility or SEO/conversion improvement.