feat(datatype): add SpiketrainFrame for SpikeBinner node output - #84
Merged
Merged
Conversation
The SpikeBinner node emits one bin of per-channel spike counts at a fixed cadence. There was no message for it -- DataType.kSpiketrain existed with nothing to carry over the wire -- so the node could not be tapped and nexus-desktop's binned-spike viewer had nothing to decode. Bins are emitted even when empty so a consumer can tell a silent channel apart from a stalled stream. Bumps VERSION to 2.5.0 (additive message, no breaking change).
Contributor
|
rebase first, then lgtm |
namthor9
added a commit
to sciencecorp/synapse-typescript
that referenced
this pull request
Sep 24, 2026
Points the submodule at 065ff8c (sciencecorp/synapse-api#84, merged). Bumps the package to 2.4.0 for a manual publish; release-please was removed in #51, so it will not do this.
namthor9
added a commit
to sciencecorp/synapse-typescript
that referenced
this pull request
Sep 24, 2026
…55) * feat(api): bump synapse-api to 2.5.0 for SpiketrainFrame Picks up the new synapse.SpiketrainFrame message, which the SpikeBinner node's tap publishes and nexus-desktop's binned-spike viewer decodes. package.json is left to release-please; src/api and dist are generated. * chore: point synapse-api at merged #84 and bump version to 2.4.0 Points the submodule at 065ff8c (sciencecorp/synapse-api#84, merged). Bumps the package to 2.4.0 for a manual publish; release-please was removed in #51, so it will not do this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
synapse.SpiketrainFrametoapi/datatype.proto, the output message for the SpikeBinner node. There was previously no message for binned spiketrains, so the binner could not exist and Nexus had nothing to view.Changes
SpiketrainFramemessage:timestamp_ns(bin start, same clock asBroadbandFrame.timestamp_ns),sequence_number,bin_size_ms,spike_counts(one per channel),channel_ids(empty = contiguous 0..n-1, same convention asBroadbandFrame.channel_ranges),unix_timestamp_ns.sequence_numbergaps mean dropped bins.VERSION→ 2.5.0. Additive only, no breaking changes.Testing
pbjs; round-tripped through encode/decode in synapse-typescript.synapsectlsupport is a follow-up).Merge order
This is first in the chain; the synapse-typescript, headstage, and nexus-desktop PRs all depend on it.
mainonVERSION(main is now 2.4.3 after #83). Needs a rebase. 2.5.0 still works as the new version. After the merge, the synapse-typescript and headstage submodule pointers (currently on07cc0a3) need moving to the merged commit.